Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752751AbdF3Ubg (ORCPT ); Fri, 30 Jun 2017 16:31:36 -0400 Received: from gateway30.websitewelcome.com ([192.185.152.11]:21994 "EHLO gateway30.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751692AbdF3Ubf (ORCPT ); Fri, 30 Jun 2017 16:31:35 -0400 Date: Fri, 30 Jun 2017 15:31:32 -0500 Message-ID: <20170630153132.Horde.yKnCrx-eIdMDEfUpCJ07mLx@gator4166.hostgator.com> From: "Gustavo A. R. Silva" To: Takashi Iwai Cc: Jaroslav Kysela , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] ALSA: x86: fix error return code in hdmi_lpe_audio_probe() References: <20170630151244.Horde.nPNra38wHbiLkXMM9mTTsxB@gator4166.hostgator.com> <20170630201841.GA8057@embeddedgus> In-Reply-To: User-Agent: Horde Application Framework 5 Content-Type: text/plain; charset=utf-8; format=flowed; DelSp=Yes MIME-Version: 1.0 Content-Disposition: inline X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 108.167.133.22 X-Exim-ID: 1dR2Zg-001Ufy-4X X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: gator4166.hostgator.com [108.167.133.22]:49504 X-Source-Auth: garsilva@embeddedor.com X-Email-Count: 9 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1466 Lines: 60 Hi Takashi, Quoting Takashi Iwai : > On Fri, 30 Jun 2017 22:18:41 +0200, > Gustavo A. R. Silva wrote: >> >> Also, >> notice that platform_get_irq() no longer returns 0 on error. > > There is no change by your patch in this regard, right? > You are correct. I just pointing it out. This is the commit that changed the platform_get_irq code: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=e330b9a6bb35dc7097a4f02cb1ae7b6f96df92af > > Takashi > >> Print error message and propagate the return value of platform_get_irq >> on failure. >> >> Signed-off-by: Gustavo A. R. Silva >> --- >> Changes in v2: >> Fix error in commit message. >> >> sound/x86/intel_hdmi_audio.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/sound/x86/intel_hdmi_audio.c b/sound/x86/intel_hdmi_audio.c >> index c19efc9..a095150 100644 >> --- a/sound/x86/intel_hdmi_audio.c >> +++ b/sound/x86/intel_hdmi_audio.c >> @@ -1758,8 +1758,8 @@ static int hdmi_lpe_audio_probe(struct >> platform_device *pdev) >> /* get resources */ >> irq = platform_get_irq(pdev, 0); >> if (irq < 0) { >> - dev_err(&pdev->dev, "Could not get irq resource\n"); >> - return -ENODEV; >> + dev_err(&pdev->dev, "Could not get irq resource: %d\n", irq); >> + return irq; >> } >> >> res_mmio = platform_get_resource(pdev, IORESOURCE_MEM, 0); >> -- >> 2.5.0 >> >> Thanks -- Gustavo A. R. Silva