Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752998AbdF3VJx (ORCPT ); Fri, 30 Jun 2017 17:09:53 -0400 Received: from mail-lf0-f45.google.com ([209.85.215.45]:33441 "EHLO mail-lf0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752772AbdF3VJw (ORCPT ); Fri, 30 Jun 2017 17:09:52 -0400 Subject: Re: [PATCH v2] sata_rcar: fix error return code in sata_rcar_probe() To: "Gustavo A. R. Silva" , Tejun Heo References: <20170630210806.GA9391@embeddedgus> Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org From: Sergei Shtylyov Organization: Cogent Embedded Message-ID: Date: Sat, 1 Jul 2017 00:09:43 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170630210806.GA9391@embeddedgus> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 631 Lines: 18 On 07/01/2017 12:08 AM, Gustavo A. R. Silva wrote: > platform_get_irq() returns an error code, but the sata_rcar driver > ignores it and always returns -EINVAL. This is not correct, and > prevents -EPROBE_DEFER from being propagated properly. Also, > notice that platform_get_irq() no longer returns 0 on error. > > Print error message and propagate the return value of platform_get_irq > on failure. > > Cc: Sergei Shtylyov > Signed-off-by: Gustavo A. R. Silva You forgot to collect: Acked-by: Sergei Shtylyov MBR, Sergei