Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753025AbdF3VMA (ORCPT ); Fri, 30 Jun 2017 17:12:00 -0400 Received: from gateway24.websitewelcome.com ([192.185.51.35]:14099 "EHLO gateway24.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752972AbdF3VL7 (ORCPT ); Fri, 30 Jun 2017 17:11:59 -0400 Date: Fri, 30 Jun 2017 16:11:56 -0500 Message-ID: <20170630161156.Horde.id9lz2qyRnuSBKx3KBfTM7r@gator4166.hostgator.com> From: "Gustavo A. R. Silva" To: Sergei Shtylyov Cc: Tejun Heo , linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] sata_rcar: fix error return code in sata_rcar_probe() References: <20170630210806.GA9391@embeddedgus> In-Reply-To: User-Agent: Horde Application Framework 5 Content-Type: text/plain; charset=utf-8; format=flowed; DelSp=Yes MIME-Version: 1.0 Content-Disposition: inline X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 108.167.133.22 X-Exim-ID: 1dR3Cm-001xuN-K7 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: gator4166.hostgator.com [108.167.133.22]:10249 X-Source-Auth: garsilva@embeddedor.com X-Email-Count: 5 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 769 Lines: 29 Quoting Sergei Shtylyov : > On 07/01/2017 12:08 AM, Gustavo A. R. Silva wrote: > >> platform_get_irq() returns an error code, but the sata_rcar driver >> ignores it and always returns -EINVAL. This is not correct, and >> prevents -EPROBE_DEFER from being propagated properly. Also, >> notice that platform_get_irq() no longer returns 0 on error. >> >> Print error message and propagate the return value of platform_get_irq >> on failure. >> >> Cc: Sergei Shtylyov >> Signed-off-by: Gustavo A. R. Silva > > You forgot to collect: > > Acked-by: Sergei Shtylyov > Oh I'm sorry. Should I send v3? Thanks -- Gustavo A. R. Silva