Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752050AbdF3X4M (ORCPT ); Fri, 30 Jun 2017 19:56:12 -0400 Received: from mail-pf0-f196.google.com ([209.85.192.196]:35289 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751922AbdF3X4K (ORCPT ); Fri, 30 Jun 2017 19:56:10 -0400 Date: Fri, 30 Jun 2017 16:56:05 -0700 From: Eduardo Valentin To: Mikko Perttunen Cc: robh+dt@kernel.org, mark.rutland@arm.com, rui.zhang@intel.com, thierry.reding@gmail.com, jonathanh@nvidia.com, devicetree@vger.kernel.org, linux-pm@vger.kernel.org, linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/4] arm64: tegra: Add BPMP thermal sensor to Tegra186 Message-ID: <20170630235603.GA2943@localhost.localdomain> References: <20170616112825.31025-1-mperttunen@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170616112825.31025-1-mperttunen@nvidia.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v5UNvADi021207 Content-Length: 2135 Lines: 82 On Fri, Jun 16, 2017 at 02:28:22PM +0300, Mikko Perttunen wrote: > This adds the thermal sensor device provided by the BPMP, and the > relevant thermal sensors to the Tegra186 device tree. > > Signed-off-by: Mikko Perttunen > --- > arch/arm64/boot/dts/nvidia/tegra186.dtsi | 48 ++++++++++++++++++++++++++++++++ > 1 file changed, 48 insertions(+) > > diff --git a/arch/arm64/boot/dts/nvidia/tegra186.dtsi b/arch/arm64/boot/dts/nvidia/tegra186.dtsi > index 5e62e68ac053..5c19ea74da24 100644 > --- a/arch/arm64/boot/dts/nvidia/tegra186.dtsi > +++ b/arch/arm64/boot/dts/nvidia/tegra186.dtsi > @@ -4,6 +4,7 @@ > #include > #include > #include > +#include > > / { > compatible = "nvidia,tegra186"; > @@ -444,6 +445,53 @@ > #size-cells = <0>; > status = "disabled"; > }; > + > + bpmp_thermal: thermal { > + compatible = "nvidia,tegra186-bpmp-thermal"; > + #thermal-sensor-cells = <1>; > + }; > + }; > + > + thermal-zones { > + a57 { > + polling-delay = <0>; > + polling-delay-passive = <1000>; > + > + thermal-sensors = > + <&bpmp_thermal TEGRA186_BPMP_THERMAL_ZONE_CPU>; > + }; > + > + denver { > + polling-delay = <0>; > + polling-delay-passive = <1000>; > + > + thermal-sensors = > + <&bpmp_thermal TEGRA186_BPMP_THERMAL_ZONE_AUX>; > + }; > + > + gpu { > + polling-delay = <0>; > + polling-delay-passive = <1000>; > + > + thermal-sensors = > + <&bpmp_thermal TEGRA186_BPMP_THERMAL_ZONE_GPU>; > + }; > + > + pll { > + polling-delay = <0>; > + polling-delay-passive = <1000>; > + > + thermal-sensors = > + <&bpmp_thermal TEGRA186_BPMP_THERMAL_ZONE_PLLX>; > + }; > + > + always_on { > + polling-delay = <0>; > + polling-delay-passive = <1000>; > + > + thermal-sensors = > + <&bpmp_thermal TEGRA186_BPMP_THERMAL_ZONE_AO>; > + }; All the above zones are lacking mandatory fields. Please refer to the thermal binding documentation. > }; > > timer { > -- > 2.13.1 >