Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752240AbdGADtw (ORCPT ); Fri, 30 Jun 2017 23:49:52 -0400 Received: from mail-yw0-f175.google.com ([209.85.161.175]:32940 "EHLO mail-yw0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751888AbdGADtv (ORCPT ); Fri, 30 Jun 2017 23:49:51 -0400 MIME-Version: 1.0 In-Reply-To: <660571c18986eb8c7025d4b68c0be5f7df48e569.1498810220.git.jerry.hoemann@hpe.com> References: <660571c18986eb8c7025d4b68c0be5f7df48e569.1498810220.git.jerry.hoemann@hpe.com> From: Dan Williams Date: Fri, 30 Jun 2017 20:49:50 -0700 Message-ID: Subject: Re: [PATCH v4 6/6] nfit allow override of root dsm mask To: Jerry Hoemann Cc: "linux-nvdimm@lists.01.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1143 Lines: 26 On Fri, Jun 30, 2017 at 9:09 AM, Jerry Hoemann wrote: > Have module parameter override_dsm_mask override the dsm_mask for > root calls like it does for non-root dsm calls. > > Signed-off-by: Jerry Hoemann > --- > drivers/acpi/nfit/core.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/acpi/nfit/core.c b/drivers/acpi/nfit/core.c > index 4e24d69..87acaf2 100644 > --- a/drivers/acpi/nfit/core.c > +++ b/drivers/acpi/nfit/core.c > @@ -1641,6 +1641,8 @@ static void acpi_nfit_init_dsms(struct acpi_nfit_desc *acpi_desc) > set_bit(ND_CMD_CALL, &nd_desc->cmd_mask); > > dsm_mask = 0x3bf; > + if (override_dsm_mask) > + dsm_mask = override_dsm_mask; > for_each_set_bit(i, &dsm_mask, BITS_PER_LONG) > if (acpi_check_dsm(adev->handle, uuid, 1, 1ULL << i)) > set_bit(i, &nd_desc->bus_dsm_mask); Another reason not to apply this is to take a look at what happened with the introduction of _LSI, _LSR, and _LSW. We should not expect that _DSM will keep being used for future NVDIMM root bus methods.