Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754347AbdFSSkD (ORCPT + 2 others); Mon, 19 Jun 2017 14:40:03 -0400 Received: from wtarreau.pck.nerim.net ([62.212.114.60]:52762 "EHLO 1wt.eu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754308AbdFSSj7 (ORCPT ); Mon, 19 Jun 2017 14:39:59 -0400 From: Willy Tarreau To: linux-kernel@vger.kernel.org, stable@vger.kernel.org, linux@roeck-us.net Cc: Max Bires , Jiri Slaby , Willy Tarreau Subject: [PATCH 3.10 235/268] char: lack of bool string made CONFIG_DEVPORT always on Date: Mon, 19 Jun 2017 20:32:14 +0200 Message-Id: <1497897167-14556-236-git-send-email-w@1wt.eu> X-Mailer: git-send-email 2.8.0.rc2.1.gbe9624a In-Reply-To: <1497897167-14556-1-git-send-email-w@1wt.eu> References: <1497897167-14556-1-git-send-email-w@1wt.eu> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: From: Max Bires commit f2cfa58b136e4b06a9b9db7af5ef62fbb5992f62 upstream. Without a bool string present, using "# CONFIG_DEVPORT is not set" in defconfig files would not actually unset devport. This esnured that /dev/port was always on, but there are reasons a user may wish to disable it (smaller kernel, attack surface reduction) if it's not being used. Adding a message here in order to make this user visible. Signed-off-by: Max Bires Acked-by: Arnd Bergmann Signed-off-by: Jiri Slaby Signed-off-by: Willy Tarreau --- drivers/char/Kconfig | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/char/Kconfig b/drivers/char/Kconfig index 3087892..8ccb96a 100644 --- a/drivers/char/Kconfig +++ b/drivers/char/Kconfig @@ -579,9 +579,12 @@ config TELCLOCK controlling the behavior of this hardware. config DEVPORT - bool + bool "/dev/port character device" depends on ISA || PCI default y + help + Say Y here if you want to support the /dev/port device. The /dev/port + device is similar to /dev/mem, but for I/O ports. source "drivers/s390/char/Kconfig" -- 2.8.0.rc2.1.gbe9624a