Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753774AbdFSSyR (ORCPT + 2 others); Mon, 19 Jun 2017 14:54:17 -0400 Received: from wtarreau.pck.nerim.net ([62.212.114.60]:52658 "EHLO 1wt.eu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753646AbdFSSid (ORCPT ); Mon, 19 Jun 2017 14:38:33 -0400 From: Willy Tarreau To: linux-kernel@vger.kernel.org, stable@vger.kernel.org, linux@roeck-us.net Cc: Arvind Yadav , Tejun Heo , Jiri Slaby , Willy Tarreau Subject: [PATCH 3.10 138/268] ata: sata_mv:- Handle return value of devm_ioremap. Date: Mon, 19 Jun 2017 20:30:37 +0200 Message-Id: <1497897167-14556-139-git-send-email-w@1wt.eu> X-Mailer: git-send-email 2.8.0.rc2.1.gbe9624a In-Reply-To: <1497897167-14556-1-git-send-email-w@1wt.eu> References: <1497897167-14556-1-git-send-email-w@1wt.eu> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: From: Arvind Yadav commit 064c3db9c564cc5be514ac21fb4aa26cc33db746 upstream. Here, If devm_ioremap will fail. It will return NULL. Then hpriv->base = NULL - 0x20000; Kernel can run into a NULL-pointer dereference. This error check will avoid NULL pointer dereference. Signed-off-by: Arvind Yadav Signed-off-by: Tejun Heo Signed-off-by: Jiri Slaby Signed-off-by: Willy Tarreau --- drivers/ata/sata_mv.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/ata/sata_mv.c b/drivers/ata/sata_mv.c index b256ff5..d9f45c8 100644 --- a/drivers/ata/sata_mv.c +++ b/drivers/ata/sata_mv.c @@ -4097,6 +4097,9 @@ static int mv_platform_probe(struct platform_device *pdev) host->iomap = NULL; hpriv->base = devm_ioremap(&pdev->dev, res->start, resource_size(res)); + if (!hpriv->base) + return -ENOMEM; + hpriv->base -= SATAHC0_REG_BASE; #if defined(CONFIG_HAVE_CLK) -- 2.8.0.rc2.1.gbe9624a