Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753855AbdFSSiB (ORCPT + 2 others); Mon, 19 Jun 2017 14:38:01 -0400 Received: from wtarreau.pck.nerim.net ([62.212.114.60]:52581 "EHLO 1wt.eu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753812AbdFSSh4 (ORCPT ); Mon, 19 Jun 2017 14:37:56 -0400 From: Willy Tarreau To: linux-kernel@vger.kernel.org, stable@vger.kernel.org, linux@roeck-us.net Cc: Yang Yang , jiang.biao2@zte.com.cn, jiang.zhengxiong@zte.com.cn, zhong.weidong@zte.com.cn, deng.huali@zte.com.cn, Peter Zijlstra , Thomas Gleixner , Willy Tarreau Subject: [PATCH 3.10 148/268] futex: Move futex_init() to core_initcall Date: Mon, 19 Jun 2017 20:30:47 +0200 Message-Id: <1497897167-14556-149-git-send-email-w@1wt.eu> X-Mailer: git-send-email 2.8.0.rc2.1.gbe9624a In-Reply-To: <1497897167-14556-1-git-send-email-w@1wt.eu> References: <1497897167-14556-1-git-send-email-w@1wt.eu> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: From: Yang Yang commit 25f71d1c3e98ef0e52371746220d66458eac75bc upstream. The UEVENT user mode helper is enabled before the initcalls are executed and is available when the root filesystem has been mounted. The user mode helper is triggered by device init calls and the executable might use the futex syscall. futex_init() is marked __initcall which maps to device_initcall, but there is no guarantee that futex_init() is invoked _before_ the first device init call which triggers the UEVENT user mode helper. If the user mode helper uses the futex syscall before futex_init() then the syscall crashes with a NULL pointer dereference because the futex subsystem has not been initialized yet. Move futex_init() to core_initcall so futexes are initialized before the root filesystem is mounted and the usermode helper becomes available. [ tglx: Rewrote changelog ] Signed-off-by: Yang Yang Cc: jiang.biao2@zte.com.cn Cc: jiang.zhengxiong@zte.com.cn Cc: zhong.weidong@zte.com.cn Cc: deng.huali@zte.com.cn Cc: Peter Zijlstra Link: http://lkml.kernel.org/r/1483085875-6130-1-git-send-email-yang.yang29@zte.com.cn Signed-off-by: Thomas Gleixner Signed-off-by: Willy Tarreau --- kernel/futex.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/futex.c b/kernel/futex.c index edc4bea..9bbeda0 100644 --- a/kernel/futex.c +++ b/kernel/futex.c @@ -2902,4 +2902,4 @@ static int __init futex_init(void) return 0; } -__initcall(futex_init); +core_initcall(futex_init); -- 2.8.0.rc2.1.gbe9624a