Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752198AbdGAHmr (ORCPT ); Sat, 1 Jul 2017 03:42:47 -0400 Received: from mail-yb0-f195.google.com ([209.85.213.195]:35387 "EHLO mail-yb0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751400AbdGAHmp (ORCPT ); Sat, 1 Jul 2017 03:42:45 -0400 MIME-Version: 1.0 Reply-To: myungjoo.ham@gmail.com In-Reply-To: <5956058A.3090304@samsung.com> References: <20170630072211.GA21867@embeddedgus> <5956058A.3090304@samsung.com> From: MyungJoo Ham Date: Sat, 1 Jul 2017 16:42:29 +0900 X-Google-Sender-Auth: 2HE4nPtBOgbrI9FaYv6PvDBbbbI Message-ID: Subject: Re: [PATCH] devfreq: tegra: fix error code in tegra_devfreq_probe() To: Chanwoo Choi Cc: "Gustavo A. R. Silva" , Kyungmin Park , Thierry Reding , Jonathan Hunter , Linux PM list , linux-tegra@vger.kernel.org, LKML Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v617grLl025460 Content-Length: 1257 Lines: 45 On Fri, Jun 30, 2017 at 5:02 PM, Chanwoo Choi wrote: > Hi, > > On 2017년 06월 30일 16:22, Gustavo A. R. Silva wrote: >> Print and propagate the return value of platform_get_irq on failure. >> >> Signed-off-by: Gustavo A. R. Silva >> --- >> drivers/devfreq/tegra-devfreq.c | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/devfreq/tegra-devfreq.c b/drivers/devfreq/tegra-devfreq.c >> index 214fff9..ae71215 100644 >> --- a/drivers/devfreq/tegra-devfreq.c >> +++ b/drivers/devfreq/tegra-devfreq.c >> @@ -688,9 +688,9 @@ static int tegra_devfreq_probe(struct platform_device *pdev) >> } >> >> irq = platform_get_irq(pdev, 0); >> - if (irq <= 0) { >> - dev_err(&pdev->dev, "Failed to get IRQ\n"); >> - return -ENODEV; >> + if (irq < 0) { >> + dev_err(&pdev->dev, "Failed to get IRQ: %d\n", irq); >> + return irq; >> } >> >> platform_set_drvdata(pdev, tegra); >> > > Reviewed-by: Chanwoo Choi Acked-by: MyungJoo Ham > > -- > Best Regards, > Chanwoo Choi > Samsung Electronics -- MyungJoo Ham, Ph.D. S/W Center, Samsung Electronics