Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S263176AbTFPAgN (ORCPT ); Sun, 15 Jun 2003 20:36:13 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S263179AbTFPAgN (ORCPT ); Sun, 15 Jun 2003 20:36:13 -0400 Received: from are.twiddle.net ([64.81.246.98]:38550 "EHLO are.twiddle.net") by vger.kernel.org with ESMTP id S263176AbTFPAgM (ORCPT ); Sun, 15 Jun 2003 20:36:12 -0400 Date: Sun, 15 Jun 2003 17:49:57 -0700 From: Richard Henderson To: Rusty Russell Cc: Linus Torvalds , linux-kernel@vger.kernel.org, ak@muc.de, Roman Zippel Subject: Re: [PATCH] Fix undefined/miscompiled construct in kernel parameters Message-ID: <20030616004957.GA15350@twiddle.net> Mail-Followup-To: Rusty Russell , Linus Torvalds , linux-kernel@vger.kernel.org, ak@muc.de, Roman Zippel References: <20030616002453.8A9B72C078@lists.samba.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20030616002453.8A9B72C078@lists.samba.org> User-Agent: Mutt/1.4i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 689 Lines: 16 On Mon, Jun 16, 2003 at 10:23:41AM +1000, Rusty Russell wrote: > Since Andi reports that even that doesn't work for x86-64, I'd say > apply this patch based on his: it's an arbitrary change anyway. No, Andi located the *real* problem. The compiler was over-aligning these objects, which added padding, which broke the array semantics you were looking for. The solution is to add an attribute aligned; he's sent a patch to Linus already. r~ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/