Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752281AbdGAVPy (ORCPT ); Sat, 1 Jul 2017 17:15:54 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:28529 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752089AbdGAVPx (ORCPT ); Sat, 1 Jul 2017 17:15:53 -0400 To: Arnd Bergmann Cc: qla2xxx-upstream@qlogic.com, "James E.J. Bottomley" , "Martin K. Petersen" , Quinn Tran , Himanshu Madhani , Nicholas Bellinger , Darren Trapp , Anil Gurumurthy , Duane Grigsby , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] scsi: qla2xxx: avoid unused-function warning From: "Martin K. Petersen" Organization: Oracle Corporation References: <20170630161056.30630-1-arnd@arndb.de> <20170630161056.30630-2-arnd@arndb.de> Date: Sat, 01 Jul 2017 17:15:33 -0400 In-Reply-To: <20170630161056.30630-2-arnd@arndb.de> (Arnd Bergmann's message of "Fri, 30 Jun 2017 18:10:40 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 708 Lines: 17 Arnd, > When NVMe support is disabled, we get a couple of harmless warnings: > > drivers/scsi/qla2xxx/qla_nvme.c:667:13: error: 'qla_nvme_unregister_remote_port' defined but not used [-Werror=unused-function] > drivers/scsi/qla2xxx/qla_nvme.c:634:13: error: 'qla_nvme_abort_all' defined but not used [-Werror=unused-function] > drivers/scsi/qla2xxx/qla_nvme.c:604:12: error: 'qla_nvme_wait_on_rport_del' defined but not used [-Werror=unused-function] > > This replaces the preprocessor checks in the code with equivalent > compiler conditionals, which lets gcc drop the unused functions > without warning, and is nicer to read. Applied to 4.13/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering