Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752266AbdGBKJz (ORCPT ); Sun, 2 Jul 2017 06:09:55 -0400 Received: from Galois.linutronix.de ([146.0.238.70]:39437 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751889AbdGBKJx (ORCPT ); Sun, 2 Jul 2017 06:09:53 -0400 Date: Sun, 2 Jul 2017 12:09:49 +0200 (CEST) From: Thomas Gleixner To: Vikas Shivappa cc: x86@kernel.org, linux-kernel@vger.kernel.org, hpa@zytor.com, peterz@infradead.org, ravi.v.shankar@intel.com, vikas.shivappa@intel.com, tony.luck@intel.com, fenghua.yu@intel.com, andi.kleen@intel.com Subject: Re: [PATCH 09/21] x86/intel_rdt: Simplify info and base file lists In-Reply-To: <1498503368-20173-10-git-send-email-vikas.shivappa@linux.intel.com> Message-ID: References: <1498503368-20173-1-git-send-email-vikas.shivappa@linux.intel.com> <1498503368-20173-10-git-send-email-vikas.shivappa@linux.intel.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 462 Lines: 20 On Mon, 26 Jun 2017, Vikas Shivappa wrote: > @@ -82,6 +82,7 @@ struct rdt_resource rdt_resources_all[] = { > }, > .parse_ctrlval = parse_cbm, > .format_str = "%d=%0*x", > + .fflags = RFTYPE_RES_CACHE, > }, Can you please convert that array to use explicit array member initializers? I've noticed this back when I reviewed the intial RDT implementation, but it somehow escaped. i.e.: [RESOURCE_ID] = { ..... } Thanks, tglx