Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752098AbdGBSHb (ORCPT <rfc822;w@1wt.eu>);
        Sun, 2 Jul 2017 14:07:31 -0400
Received: from Galois.linutronix.de ([146.0.238.70]:40265 "EHLO
        Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751777AbdGBSH3 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sun, 2 Jul 2017 14:07:29 -0400
Date: Sun, 2 Jul 2017 20:07:23 +0200 (CEST)
From: Thomas Gleixner <tglx@linutronix.de>
To: Dou Liyang <douly.fnst@cn.fujitsu.com>
cc: x86@kernel.org, linux-kernel@vger.kernel.org,
        xen-devel@lists.xenproject.org, mingo@kernel.org, hpa@zytor.com,
        ebiederm@xmission.com, bhe@redhat.com, boris.ostrovsky@oracle.com,
        peterz@infradead.org, izumi.taku@jp.fujitsu.com
Subject: Re: [PATCH v5 05/12] x86/apic: Unify interrupt mode setup for
 SMP-capable system
In-Reply-To: <a8d9b8d0b6c908a570f3ee40c59ef20bd61a21e4.1498795030.git.douly.fnst@cn.fujitsu.com>
Message-ID: <alpine.DEB.2.20.1707021957180.2296@nanos>
References: <cover.1498795030.git.douly.fnst@cn.fujitsu.com> <a8d9b8d0b6c908a570f3ee40c59ef20bd61a21e4.1498795030.git.douly.fnst@cn.fujitsu.com>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 801
Lines: 32

On Fri, 30 Jun 2017, Dou Liyang wrote:
> -static int __init apic_intr_mode_select(void)
> +static int __init apic_intr_mode_select(int *upmode)
>  {
>  	/* Check kernel option */
>  	if (disable_apic) {
> @@ -1206,12 +1208,30 @@ static int __init apic_intr_mode_select(void)
>  	if (!smp_found_config) {
>  		disable_ioapic_support();
>  
> -		if (!acpi_lapic)
> +		if (!acpi_lapic) {
>  			pr_info("APIC: ACPI MADT or MP tables are not detected\n");
> +			*upmode = true;

That store and extra argument is pointless. 

> +
> +			return APIC_VIRTUAL_WIRE_NO_CONFIG;

You added an extra return code, which you can use exactly for that purpose
at the callsite.


Aside of that, if you use int * then use numbers, if you use bool then use
true/false. But mixing that is horrible.

> +		}

Thanks,

	tglx