Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752089AbdGBTSp (ORCPT <rfc822;w@1wt.eu>);
        Sun, 2 Jul 2017 15:18:45 -0400
Received: from Galois.linutronix.de ([146.0.238.70]:40354 "EHLO
        Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751810AbdGBTSm (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sun, 2 Jul 2017 15:18:42 -0400
Date: Sun, 2 Jul 2017 21:18:39 +0200 (CEST)
From: Thomas Gleixner <tglx@linutronix.de>
To: Dou Liyang <douly.fnst@cn.fujitsu.com>
cc: x86@kernel.org, linux-kernel@vger.kernel.org,
        xen-devel@lists.xenproject.org, mingo@kernel.org, hpa@zytor.com,
        ebiederm@xmission.com, bhe@redhat.com, boris.ostrovsky@oracle.com,
        peterz@infradead.org, izumi.taku@jp.fujitsu.com
Subject: Re: [PATCH v5 10/12] x86/xen: Bypass intr mode setup in enlighten_pv
 system
In-Reply-To: <2545ef73fde4e3cf65080b056669dadd3578ff8a.1498795030.git.douly.fnst@cn.fujitsu.com>
Message-ID: <alpine.DEB.2.20.1707022117180.2296@nanos>
References: <cover.1498795030.git.douly.fnst@cn.fujitsu.com> <2545ef73fde4e3cf65080b056669dadd3578ff8a.1498795030.git.douly.fnst@cn.fujitsu.com>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 424
Lines: 15

On Fri, 30 Jun 2017, Dou Liyang wrote:

> xen_smp_ops overwrites smp_prepare_cpus to xen_pv_smp_prepare_cpus
> which initializes interrupt itself.
> 
> Touching the intr_mode_init causes unexpected results on the system.
> 
> Bypass it in enlighten_pv system.

So that's the wrong patch order then. You broke XEN at some point with your
changes. You need to prevent that breakage upfront not after the fact.

Thanks,

	tglx