Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752089AbdGBVqE (ORCPT ); Sun, 2 Jul 2017 17:46:04 -0400 Received: from mail.kernel.org ([198.145.29.99]:54000 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751894AbdGBVqD (ORCPT ); Sun, 2 Jul 2017 17:46:03 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 97D9A22BE2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=helgaas@kernel.org Date: Sun, 2 Jul 2017 16:46:00 -0500 From: Bjorn Helgaas To: Arvind Yadav Cc: horms@verge.net.au, bhelgaas@google.com, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org Subject: Re: [PATCH] PCI: rcar-gen2: make of_device_ids const Message-ID: <20170702214600.GH18324@bhelgaas-glaptop.roam.corp.google.com> References: <99e5ddc3b23962b22740dc93113d178f6f98df2f.1498210098.git.arvind.yadav.cs@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <99e5ddc3b23962b22740dc93113d178f6f98df2f.1498210098.git.arvind.yadav.cs@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1062 Lines: 29 On Fri, Jun 23, 2017 at 02:59:52PM +0530, Arvind Yadav wrote: > of_device_ids are not supposed to change at runtime. All functions > working with of_device_ids provided by work with const > of_device_ids. So mark the non-const structs as const. > > Signed-off-by: Arvind Yadav Applied with acks from Simon & Geert to pci/host-rcar for v4.13, thanks! > --- > drivers/pci/host/pci-rcar-gen2.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pci/host/pci-rcar-gen2.c b/drivers/pci/host/pci-rcar-gen2.c > index 8534859..6f87968 100644 > --- a/drivers/pci/host/pci-rcar-gen2.c > +++ b/drivers/pci/host/pci-rcar-gen2.c > @@ -429,7 +429,7 @@ static int rcar_pci_probe(struct platform_device *pdev) > return 0; > } > > -static struct of_device_id rcar_pci_of_match[] = { > +static const struct of_device_id rcar_pci_of_match[] = { > { .compatible = "renesas,pci-r8a7790", }, > { .compatible = "renesas,pci-r8a7791", }, > { .compatible = "renesas,pci-r8a7794", }, > -- > 1.9.1 >