Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752270AbdGCB0y (ORCPT ); Sun, 2 Jul 2017 21:26:54 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:60281 "EHLO out1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752121AbdGCB0w (ORCPT ); Sun, 2 Jul 2017 21:26:52 -0400 X-ME-Sender: X-Sasl-enc: z4xpkXE8e+OQp2ohu5UsuXdxB9rQOaOkMFbVWbLk8g9b 1499045211 From: "Zi Yan" To: "Kirill A. Shutemov" Cc: kirill.shutemov@linux.intel.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, minchan@kernel.org, vbabka@suse.cz, mgorman@techsingularity.net, mhocko@kernel.org, khandual@linux.vnet.ibm.com, dnellans@nvidia.com, dave.hansen@intel.com, n-horiguchi@ah.jp.nec.com Subject: Re: [PATCH v8 05/10] mm: thp: enable thp migration in generic path Date: Sun, 02 Jul 2017 21:26:48 -0400 Message-ID: In-Reply-To: <20170702175732.okngzb6y6gwxrpdo@node.shutemov.name> References: <20170701134008.110579-1-zi.yan@sent.com> <20170701134008.110579-6-zi.yan@sent.com> <20170702175732.okngzb6y6gwxrpdo@node.shutemov.name> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=_MailMate_3481C5A9-04D1-4101-944E-1D9263AC69C9_="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Mailer: MailMate (2.0BETAr6086) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1671 Lines: 52 This is an OpenPGP/MIME signed message (RFC 3156 and 4880). --=_MailMate_3481C5A9-04D1-4101-944E-1D9263AC69C9_= Content-Type: text/plain; markup=markdown Content-Transfer-Encoding: quoted-printable On 2 Jul 2017, at 13:57, Kirill A. Shutemov wrote: > On Sat, Jul 01, 2017 at 09:40:03AM -0400, Zi Yan wrote: >> --- a/mm/rmap.c >> +++ b/mm/rmap.c >> @@ -1302,6 +1302,7 @@ static bool try_to_unmap_one(struct page *page, = struct vm_area_struct *vma, >> bool ret =3D true; >> enum ttu_flags flags =3D (enum ttu_flags)arg; >> >> + >> /* munlock has nothing to gain from examining un-locked vmas */ >> if ((flags & TTU_MUNLOCK) && !(vma->vm_flags & VM_LOCKED)) >> return true; > > With exception of this useless hunk, looks good to me > > Acked-by: Kirill A. Shutemov > Thanks. BTW, is this Acked-by for Patch 5 or both Path 5 and 6? -- Best Regards Yan Zi --=_MailMate_3481C5A9-04D1-4101-944E-1D9263AC69C9_= Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQEcBAEBCgAGBQJZWZ1YAAoJEEGLLxGcTqbMhjQIAIC0wohlGQG38vQ0b1rXCb7v PI0dGeRswiiJKpWX12/aVQw+VyWNd47rMAK5p0cLUR42yTGpw0LPTsPvjogGnZa+ HSVx7VcFvpBsXHLkMaVjADCxXB7N4skcST3HIQ/h79R/DT5XHt5ylMSAVQiXQS8q wUlwAKl5lyPhql3ISKY3pgMBdtRGQ0Z4vUbjx7C5QDKY4NKXPpM1rAur67c9alFm StQoYpryNZmALutUGp0BrEyk53qNVJui+Br5pc6KfhgzU6Qx4beAQ/5p0aNobhnV pJ9w6z/zDDmej4bYczFVKaMFq9/z1PMsw8eWnjyUYNwP86/Wq+CPDzdf+3jgd9w= =lcWx -----END PGP SIGNATURE----- --=_MailMate_3481C5A9-04D1-4101-944E-1D9263AC69C9_=--