Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752214AbdGCB7C (ORCPT <rfc822;w@1wt.eu>);
        Sun, 2 Jul 2017 21:59:02 -0400
Received: from cn.fujitsu.com ([59.151.112.132]:18531 "EHLO
        heian.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org
        with ESMTP id S1752142AbdGCB7A (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sun, 2 Jul 2017 21:59:00 -0400
X-IronPort-AV: E=Sophos;i="5.22,518,1449504000"; 
   d="scan'208";a="20759204"
Subject: Re: [PATCH v5 02/12] x86/apic: Prepare for unifying the interrupt
 delivery modes setup
To: Thomas Gleixner <tglx@linutronix.de>
References: <cover.1498795030.git.douly.fnst@cn.fujitsu.com>
 <bdbbae235ff8e2c4b5b89720cc5be9fecf746abd.1498795030.git.douly.fnst@cn.fujitsu.com>
 <alpine.DEB.2.20.1707021940490.2296@nanos>
CC: <x86@kernel.org>, <linux-kernel@vger.kernel.org>,
        <xen-devel@lists.xenproject.org>, <mingo@kernel.org>, <hpa@zytor.com>,
        <ebiederm@xmission.com>, <bhe@redhat.com>,
        <boris.ostrovsky@oracle.com>, <peterz@infradead.org>,
        <izumi.taku@jp.fujitsu.com>
From: Dou Liyang <douly.fnst@cn.fujitsu.com>
Message-ID: <763ab19a-9a78-eea7-2abd-b5998cf3d9be@cn.fujitsu.com>
Date: Mon, 3 Jul 2017 09:58:53 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.20.1707021940490.2296@nanos>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.167.226.106]
X-yoursite-MailScanner-ID: 4D9E346B53E2.AAB97
X-yoursite-MailScanner: Found to be clean
X-yoursite-MailScanner-From: douly.fnst@cn.fujitsu.com
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 681
Lines: 33

Hi Thomas,

At 07/03/2017 01:47 AM, Thomas Gleixner wrote:
> On Fri, 30 Jun 2017, Dou Liyang wrote:
>> +/* Init the interrupt delivery mode for the BSP */
>> +void __init apic_intr_mode_init(void)
>> +{
>> +	switch (apic_intr_mode_select()) {
>> +	case APIC_PIC:
>> +		apic_printk(APIC_VERBOSE, KERN_INFO
>> +			"Keep in PIC mode(8259)\n");
>
> Please do not proliferate that APIC_VERBOSE, KERN_INFO mess. Clean up the
> apic_printk() macro first. Either change printk() to pr_info() or make the
> printk level dependent on the APIC verbosity.

Oops, I understood, How about the following:

pr_info("APIC: keep in PIC mode(8259)\n");


Thanks,

	dou.

>
> Thanks,
>
> 	tglx
>
>
>