Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752522AbdGCD23 (ORCPT <rfc822;w@1wt.eu>);
        Sun, 2 Jul 2017 23:28:29 -0400
Received: from cn.fujitsu.com ([59.151.112.132]:4631 "EHLO
        heian.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org
        with ESMTP id S1752470AbdGCD21 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sun, 2 Jul 2017 23:28:27 -0400
X-IronPort-AV: E=Sophos;i="5.22,518,1449504000"; 
   d="scan'208";a="20763407"
Subject: Re: [PATCH v5 09/12] x86/init: add intr_mode_init to x86_init_ops
To: Thomas Gleixner <tglx@linutronix.de>
References: <cover.1498795030.git.douly.fnst@cn.fujitsu.com>
 <1a780e5c87107497f45f1217d0c49e27f4213f88.1498795030.git.douly.fnst@cn.fujitsu.com>
 <alpine.DEB.2.20.1707022115510.2296@nanos>
CC: <x86@kernel.org>, <linux-kernel@vger.kernel.org>,
        <xen-devel@lists.xenproject.org>, <mingo@kernel.org>, <hpa@zytor.com>,
        <ebiederm@xmission.com>, <bhe@redhat.com>,
        <boris.ostrovsky@oracle.com>, <peterz@infradead.org>,
        <izumi.taku@jp.fujitsu.com>
From: Dou Liyang <douly.fnst@cn.fujitsu.com>
Message-ID: <c16cd55f-5bd1-3dc2-214f-6469b4fffd5b@cn.fujitsu.com>
Date: Mon, 3 Jul 2017 11:28:24 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.20.1707022115510.2296@nanos>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.167.226.106]
X-yoursite-MailScanner-ID: CE4BD47E98A6.AD802
X-yoursite-MailScanner: Found to be clean
X-yoursite-MailScanner-From: douly.fnst@cn.fujitsu.com
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 533
Lines: 25

Hi Thomas,

At 07/03/2017 03:16 AM, Thomas Gleixner wrote:
> On Fri, 30 Jun 2017, Dou Liyang wrote:
>> Add an unconditional x86_init_ops function which defaults to the
>> standard function and can be overridden by the early platform code.
>
> That changelog describes WHAT the patch does, but not WHY. That's useless
> as we can see WHAT the patch does from the patch itself. The WHY is the
> really important information.
>

Understood, I will add the WHY description in the next version.

Thank,

	dou.

> Thanks,
>
> 	tglx
>
>
>