Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752334AbdGCGlq (ORCPT <rfc822;w@1wt.eu>);
        Mon, 3 Jul 2017 02:41:46 -0400
Received: from Galois.linutronix.de ([146.0.238.70]:41146 "EHLO
        Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751734AbdGCGlo (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 3 Jul 2017 02:41:44 -0400
Date: Mon, 3 Jul 2017 08:41:33 +0200 (CEST)
From: Thomas Gleixner <tglx@linutronix.de>
To: Dou Liyang <douly.fnst@cn.fujitsu.com>
cc: x86@kernel.org, linux-kernel@vger.kernel.org,
        xen-devel@lists.xenproject.org, mingo@kernel.org, hpa@zytor.com,
        ebiederm@xmission.com, bhe@redhat.com, boris.ostrovsky@oracle.com,
        peterz@infradead.org, izumi.taku@jp.fujitsu.com
Subject: Re: [PATCH v5 02/12] x86/apic: Prepare for unifying the interrupt
 delivery modes setup
In-Reply-To: <763ab19a-9a78-eea7-2abd-b5998cf3d9be@cn.fujitsu.com>
Message-ID: <alpine.DEB.2.20.1707030840440.2188@nanos>
References: <cover.1498795030.git.douly.fnst@cn.fujitsu.com> <bdbbae235ff8e2c4b5b89720cc5be9fecf746abd.1498795030.git.douly.fnst@cn.fujitsu.com> <alpine.DEB.2.20.1707021940490.2296@nanos> <763ab19a-9a78-eea7-2abd-b5998cf3d9be@cn.fujitsu.com>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 803
Lines: 25

On Mon, 3 Jul 2017, Dou Liyang wrote:
> At 07/03/2017 01:47 AM, Thomas Gleixner wrote:
> > On Fri, 30 Jun 2017, Dou Liyang wrote:
> > > +/* Init the interrupt delivery mode for the BSP */
> > > +void __init apic_intr_mode_init(void)
> > > +{
> > > +	switch (apic_intr_mode_select()) {
> > > +	case APIC_PIC:
> > > +		apic_printk(APIC_VERBOSE, KERN_INFO
> > > +			"Keep in PIC mode(8259)\n");
> > 
> > Please do not proliferate that APIC_VERBOSE, KERN_INFO mess. Clean up the
> > apic_printk() macro first. Either change printk() to pr_info() or make the
> > printk level dependent on the APIC verbosity.
> 
> Oops, I understood, How about the following:
> 
> pr_info("APIC: keep in PIC mode(8259)\n");

As this is once per boot, it's ok to have that information unconditionally
printed.

Thanks,

	tglx