Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752623AbdGCGwb (ORCPT ); Mon, 3 Jul 2017 02:52:31 -0400 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:53231 "EHLO metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752198AbdGCGw3 (ORCPT ); Mon, 3 Jul 2017 02:52:29 -0400 Date: Mon, 3 Jul 2017 08:52:21 +0200 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: Romain Perier Cc: Lothar =?iso-8859-1?Q?Wa=DFmann?= , Greg Kroah-Hartman , Nandor Han , linux-arm-kernel@lists.infradead.org, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/7] serial: imx: init dma_is_{rx|tx}ing variables Message-ID: <20170703065221.imbpbybsrd3of4ec@pengutronix.de> References: <20170630120446.13994-1-romain.perier@collabora.com> <20170630120446.13994-4-romain.perier@collabora.com> <20170630141329.6144cddd@karo-electronics.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170630141329.6144cddd@karo-electronics.de> User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: 2001:67c:670:100:5054:ff:fe2a:3aa X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1396 Lines: 42 On Fri, Jun 30, 2017 at 02:13:29PM +0200, Lothar Wa?mann wrote: > Hi, > > On Fri, 30 Jun 2017 14:04:42 +0200 Romain Perier wrote: > > From: Nandor Han > > > > Initialize both dma_is_{rx|tx}ing variables when DMA is enabled to avoid > > checking uninitialized variables if port shutdown is requested before > > DMA channels get a chance to start. > > > > Signed-off-by: Nandor Han > > Signed-off-by: Romain Perier > > --- > > drivers/tty/serial/imx.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c > > index 188063d..81fb413 100644 > > --- a/drivers/tty/serial/imx.c > > +++ b/drivers/tty/serial/imx.c > > @@ -1225,6 +1225,9 @@ static void imx_enable_dma(struct imx_port *sport) > > > > imx_setup_ufcr(sport, TXTL_DMA, RXTL_DMA); > > > > + sport->dma_is_rxing = 0; > > + sport->dma_is_txing = 0; > > + > > sport->dma_is_enabled = 1; > > } > > > sport is devm_kzalloc()ed, so the variables are initialized to 0 anyway. I'd agree to Lothar's statement. Did you find this issue by inspection, or does it fix a compiler warning? Do you think there is an actual problem? Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-K?nig | Industrial Linux Solutions | http://www.pengutronix.de/ |