Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752693AbdGCHSj (ORCPT ); Mon, 3 Jul 2017 03:18:39 -0400 Received: from pegasos-out.vodafone.de ([80.84.1.38]:45713 "EHLO pegasos-out.vodafone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752279AbdGCHSg (ORCPT ); Mon, 3 Jul 2017 03:18:36 -0400 X-Spam-Flag: NO X-Spam-Score: -0.045 Authentication-Results: rohrpostix1.prod.vfnet.de (amavisd-new); dkim=pass header.i=@vodafone.de X-DKIM: OpenDKIM Filter v2.6.8 pegasos-out.vodafone.de 5EAEA261E9E Subject: Re: [PATCH] drm: radeon: constify drm_prop_enum_list structures. To: Arvind Yadav , daniel.vetter@intel.com, alexander.deucher@amd.com, christian.koenig@amd.com, airlied@linux.ie Cc: dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org References: From: =?UTF-8?Q?Christian_K=c3=b6nig?= Message-ID: Date: Mon, 3 Jul 2017 09:18:12 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2856 Lines: 71 Am 01.07.2017 um 11:47 schrieb Arvind Yadav: > drm_prop_enum_lists are not supposed to change at runtime. All functions > working with drm_prop_enum_list provided by work with > const drm_prop_enum_list. So mark the non-const structs as const. > > File size before: > text data bss dec hex filename > 18276 384 0 18660 48e4 drivers/gpu/drm/radeon/radeon_display.o > > File size After adding 'const': > text data bss dec hex filename > 18660 0 0 18660 48e4 drivers/gpu/drm/radeon/radeon_display.o > > Signed-off-by: Arvind Yadav Reviewed-by: Christian König > --- > drivers/gpu/drm/radeon/radeon_display.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/radeon/radeon_display.c b/drivers/gpu/drm/radeon/radeon_display.c > index 17d3daf..f339c1c 100644 > --- a/drivers/gpu/drm/radeon/radeon_display.c > +++ b/drivers/gpu/drm/radeon/radeon_display.c > @@ -1388,12 +1388,12 @@ static const struct drm_mode_config_funcs radeon_mode_funcs = { > .output_poll_changed = radeon_output_poll_changed > }; > > -static struct drm_prop_enum_list radeon_tmds_pll_enum_list[] = > +static const struct drm_prop_enum_list radeon_tmds_pll_enum_list[] = > { { 0, "driver" }, > { 1, "bios" }, > }; > > -static struct drm_prop_enum_list radeon_tv_std_enum_list[] = > +static const struct drm_prop_enum_list radeon_tv_std_enum_list[] = > { { TV_STD_NTSC, "ntsc" }, > { TV_STD_PAL, "pal" }, > { TV_STD_PAL_M, "pal-m" }, > @@ -1404,25 +1404,25 @@ static struct drm_prop_enum_list radeon_tv_std_enum_list[] = > { TV_STD_SECAM, "secam" }, > }; > > -static struct drm_prop_enum_list radeon_underscan_enum_list[] = > +static const struct drm_prop_enum_list radeon_underscan_enum_list[] = > { { UNDERSCAN_OFF, "off" }, > { UNDERSCAN_ON, "on" }, > { UNDERSCAN_AUTO, "auto" }, > }; > > -static struct drm_prop_enum_list radeon_audio_enum_list[] = > +static const struct drm_prop_enum_list radeon_audio_enum_list[] = > { { RADEON_AUDIO_DISABLE, "off" }, > { RADEON_AUDIO_ENABLE, "on" }, > { RADEON_AUDIO_AUTO, "auto" }, > }; > > /* XXX support different dither options? spatial, temporal, both, etc. */ > -static struct drm_prop_enum_list radeon_dither_enum_list[] = > +static const struct drm_prop_enum_list radeon_dither_enum_list[] = > { { RADEON_FMT_DITHER_DISABLE, "off" }, > { RADEON_FMT_DITHER_ENABLE, "on" }, > }; > > -static struct drm_prop_enum_list radeon_output_csc_enum_list[] = > +static const struct drm_prop_enum_list radeon_output_csc_enum_list[] = > { { RADEON_OUTPUT_CSC_BYPASS, "bypass" }, > { RADEON_OUTPUT_CSC_TVRGB, "tvrgb" }, > { RADEON_OUTPUT_CSC_YCBCR601, "ycbcr601" },