Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752716AbdGCHSo (ORCPT <rfc822;w@1wt.eu>);
        Mon, 3 Jul 2017 03:18:44 -0400
Received: from pegasos-out.vodafone.de ([80.84.1.38]:45749 "EHLO
        pegasos-out.vodafone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752680AbdGCHSj (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 3 Jul 2017 03:18:39 -0400
X-Spam-Flag: NO
X-Spam-Score: 1.6
Authentication-Results: rohrpostix1.prod.vfnet.de (amavisd-new); dkim=pass
        header.i=@vodafone.de
X-DKIM: OpenDKIM Filter v2.6.8 pegasos-out.vodafone.de 1A626261E9E
Subject: Re: [PATCH] drm: radeon: radeon_ttm: constify ttm_place structures.
To: Arvind Yadav <arvind.yadav.cs@gmail.com>, alexander.deucher@amd.com,
        christian.koenig@amd.com, airlied@linux.ie,
        amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org
References: <70c8aaafe1e873e84490b099e7b9e62eaf911953.1498986195.git.arvind.yadav.cs@gmail.com>
From: =?UTF-8?Q?Christian_K=c3=b6nig?= <deathsimple@vodafone.de>
Message-ID: <08f360d5-0998-ed8e-4748-13fbf4289eb0@vodafone.de>
Date: Mon, 3 Jul 2017 09:18:33 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.1.1
MIME-Version: 1.0
In-Reply-To: <70c8aaafe1e873e84490b099e7b9e62eaf911953.1498986195.git.arvind.yadav.cs@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1387
Lines: 35

Am 02.07.2017 um 11:06 schrieb Arvind Yadav:
> ttm_place are not supposed to change at runtime. All functions
> working with ttm_place provided by <drm/ttm/ttm_placement.h> work
> with const ttm_place. So mark the non-const structs as const.
>
> File size before:
>     text	   data	    bss	    dec	    hex	filename
>     9235	    344	    136	   9715	   25f3 drivers/gpu/drm/radeon/radeon_ttm.o
>
> File size After adding 'const':
>     text	   data	    bss	    dec	    hex	filename
>     9267	    312	    136	   9715	   25f3 drivers/gpu/drm/radeon/radeon_ttm.o
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>

Reviewed-by: Christian König <christian.koenig@amd.com>

> ---
>   drivers/gpu/drm/radeon/radeon_ttm.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c b/drivers/gpu/drm/radeon/radeon_ttm.c
> index 8b7623b..6499832 100644
> --- a/drivers/gpu/drm/radeon/radeon_ttm.c
> +++ b/drivers/gpu/drm/radeon/radeon_ttm.c
> @@ -178,7 +178,7 @@ static int radeon_init_mem_type(struct ttm_bo_device *bdev, uint32_t type,
>   static void radeon_evict_flags(struct ttm_buffer_object *bo,
>   				struct ttm_placement *placement)
>   {
> -	static struct ttm_place placements = {
> +	static const struct ttm_place placements = {
>   		.fpfn = 0,
>   		.lpfn = 0,
>   		.flags = TTM_PL_MASK_CACHING | TTM_PL_FLAG_SYSTEM