Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752605AbdGCHV6 (ORCPT ); Mon, 3 Jul 2017 03:21:58 -0400 Received: from mail-oi0-f41.google.com ([209.85.218.41]:35138 "EHLO mail-oi0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752497AbdGCHVy (ORCPT ); Mon, 3 Jul 2017 03:21:54 -0400 MIME-Version: 1.0 In-Reply-To: References: <20170630154412.3575760-1-arnd@arndb.de> From: Arnd Bergmann Date: Mon, 3 Jul 2017 09:21:53 +0200 X-Google-Sender-Auth: m8VXy40Uw-uDzhiWg0dgU06z6GI Message-ID: Subject: Re: [PATCH] [net-next] net/mlx5: include wq.o in non-ethernet build for FPGA To: Saeed Mahameed Cc: Ilan Tayari , Saeed Mahameed , Matan Barak , Leon Romanovsky , "David S. Miller" , Boris Pismenny , Or Gerlitz , Hadar Hen Zion , Kamal Heib , Maor Gottlieb , Mohamad Haj Yahia , Aviv Heller , "netdev@vger.kernel.org" , "linux-rdma@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1728 Lines: 43 On Sun, Jul 2, 2017 at 10:45 AM, Saeed Mahameed wrote: > On Fri, Jun 30, 2017 at 10:25 PM, Arnd Bergmann wrote: >> On Fri, Jun 30, 2017 at 8:58 PM, Ilan Tayari wrote: >> >>>> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/Makefile >>>> b/drivers/net/ethernet/mellanox/mlx5/core/Makefile >>>> index ca367445f864..50fe9e3c5dc2 100644 >>>> --- a/drivers/net/ethernet/mellanox/mlx5/core/Makefile >>>> +++ b/drivers/net/ethernet/mellanox/mlx5/core/Makefile >>>> @@ -9,7 +9,7 @@ mlx5_core-y := main.o cmd.o debugfs.o fw.o eq.o uar.o >>>> pagealloc.o \ >>>> mlx5_core-$(CONFIG_MLX5_ACCEL) += accel/ipsec.o >>>> >>>> mlx5_core-$(CONFIG_MLX5_FPGA) += fpga/cmd.o fpga/core.o fpga/conn.o >>>> fpga/sdk.o \ >>>> - fpga/ipsec.o >>>> + fpga/ipsec.o wq.o >>> >>> I believe we would prefer to move wq.o to mlx5_core-y. >>> Otherwise you might build it twice. >> >> That's not a problem, Kbuild is smart enough to drop duplicate object files >> that get built into the same module. >> >> If you think it's less confusing to readers of this file if it gets >> put into core, >> that's fine though, the only downside would be adding a little bit of >> code bloat for users that want neither the ethernet nor the fpga code >> (if that is a realistic use case). > > Hi Arnd, > > Thanks for the patch, your solution is good enough, but let's avoid > confusing developers with such duplications. > since the Makefile might get messy if we will keep using this method. > > I suggest to move wq.o to core or make MLX5_FPGA depend on MLX5_CORE_EN. > I will discuss this with Ilan and we will provide the fix ASAP. Ok, sounds good. Thanks! Arnd