Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752635AbdGCHXx (ORCPT ); Mon, 3 Jul 2017 03:23:53 -0400 Received: from mail-pg0-f68.google.com ([74.125.83.68]:33899 "EHLO mail-pg0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750793AbdGCHXv (ORCPT ); Mon, 3 Jul 2017 03:23:51 -0400 From: Arvind Yadav To: akpm@linux-foundation.org, hare@suse.com, dhowells@redhat.com Cc: linux-kernel@vger.kernel.org Subject: [PATCH] block: loop: constify attribute_group structures. Date: Mon, 3 Jul 2017 12:53:31 +0530 Message-Id: <4acd6af3c798df454a97d1f5b295041ff8afb4ce.1499066413.git.arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1027 Lines: 32 attribute_groups are not supposed to change at runtime. All functions working with attribute_groups provided by work with const attribute_group. So mark the non-const structs as const. File size before: text data bss dec hex filename 15816 865 88 16769 4181 drivers/block/loop.o File size After adding 'const': text data bss dec hex filename 15880 801 88 16769 4181 drivers/block/loop.o Signed-off-by: Arvind Yadav --- drivers/block/loop.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/block/loop.c b/drivers/block/loop.c index 28d9329..2e413d5 100644 --- a/drivers/block/loop.c +++ b/drivers/block/loop.c @@ -788,7 +788,7 @@ static ssize_t loop_attr_dio_show(struct loop_device *lo, char *buf) NULL, }; -static struct attribute_group loop_attribute_group = { +static const struct attribute_group loop_attribute_group = { .name = "loop", .attrs= loop_attrs, }; -- 1.9.1