Date: Mon, 3 Jul 2017 09:29:14 +0200
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Ben Hutchings <ben.hutchings@codethink.co.uk>
Cc: Yu Zhao <yuzhao@google.com>, David Rientjes <rientjes@google.com>,
        linux-kernel@vger.kernel.org, stable@vger.kernel.org,
        Michal Hocko <mhocko@suse.com>,
        Vladimir Davydov <vdavydov.dev@gmail.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH 4.4 24/30] swap: cond_resched in swap_cgroup_prepare()
Message-ID: <20170703072914.GD5888@kroah.com>
References: <20170619152033.211450261@linuxfoundation.org>
 <20170619152034.567871881@linuxfoundation.org>
 <1498757023.1935.57.camel@codethink.co.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1498757023.1935.57.camel@codethink.co.uk>
User-Agent: Mutt/1.8.3 (2017-05-23)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 986
Lines: 30

On Thu, Jun 29, 2017 at 06:23:43PM +0100, Ben Hutchings wrote:
> On Mon, 2017-06-19 at 23:20 +0800, Greg Kroah-Hartman wrote:
> > 4.4-stable review patch.  If anyone has any objections, please let me know.
> > 
> > ------------------
> > 
> > From: Yu Zhao <yuzhao@google.com>
> > 
> > commit ef70762948dde012146926720b70e79736336764 upstream.
> > 
> > I saw need_resched() warnings when swapping on large swapfile (TBs)
> > because continuously allocating many pages in swap_cgroup_prepare() took
> > too long.
> > 
> > We already cond_resched when freeing page in swap_cgroup_swapoff().  Do
> > the same for the page allocation.
> [...]
> 
> That seems to imply that this should also go into stable branches:
> 
> commit 460bcec84e11c75122ace5976214abbc596eb91b
> Author: David Rientjes <rientjes@google.com>
> Date:   Fri Apr 7 16:05:00 2017 -0700
> 
>     mm, swap_cgroup: reschedule when neeed in swap_cgroup_swapoff()
>     

Looks like it to me, thanks, now queued up.

greg k-h