DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 937CFC04B32C
Message-ID: <1499072103.771.7.camel@redhat.com>
Subject: Re: [PATCH] drm/bochs: switch fb_ops over to use drm_fb_helper_cfb
 helpers
From: Gerd Hoffmann <kraxel@redhat.com>
To: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Date: Mon, 03 Jul 2017 10:55:03 +0200
In-Reply-To: <dfbb5a6d-ede3-3907-4d01-1bcf2f3569f6@ilande.co.uk>
References: <1499032363-8290-1-git-send-email-mark.cave-ayland@ilande.co.uk>
         <20170703081116.rub4ty5ewpi5af3o@phenom.ffwll.local>
         <dfbb5a6d-ede3-3907-4d01-1bcf2f3569f6@ilande.co.uk>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 414
Lines: 15

  Hi,

> Hopefully Gerd has experience using bochs_drm with other non-x86
> systems
> and can comment further.

Just pushed to drm-misc-next, fix is correct.  bochs video memory is a
pci bar, and the framebuffer is stored there.

Using sys instead of cfb is probably a leftover from cirrus, where the
framebuffer actually in a shadow copy in system ram, due to the low
amout of (pci) video memory.

cheers,
  Gerd