Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753284AbdGCJAm (ORCPT ); Mon, 3 Jul 2017 05:00:42 -0400 Received: from mail-pf0-f178.google.com ([209.85.192.178]:35704 "EHLO mail-pf0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752852AbdGCJAk (ORCPT ); Mon, 3 Jul 2017 05:00:40 -0400 Date: Mon, 3 Jul 2017 18:00:47 +0900 From: Sergey Senozhatsky To: Arvind Yadav Cc: minchan@kernel.org, ngupta@vflare.org, sergey.senozhatsky.work@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] zram: constify attribute_group structures. Message-ID: <20170703090047.GB517@jagdpanzerIV.localdomain> References: <65680c1c4d85818f7094cbfa31c91bf28185ba1b.1499061182.git.arvind.yadav.cs@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <65680c1c4d85818f7094cbfa31c91bf28185ba1b.1499061182.git.arvind.yadav.cs@gmail.com> User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 661 Lines: 17 On (07/03/17 11:43), Arvind Yadav wrote: > attribute_groups are not supposed to change at runtime. All functions > working with attribute_groups provided by work with const > attribute_group. So mark the non-const structs as const. > > File size before: > text data bss dec hex filename > 8293 841 4 9138 23b2 drivers/block/zram/zram_drv.o > > File size After adding 'const': > text data bss dec hex filename > 8357 777 4 9138 23b2 drivers/block/zram/zram_drv.o sorry, what exactly is the improvement here? we grew .text bigger, why should we be happy about it? -ss