Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753301AbdGCJAv (ORCPT ); Mon, 3 Jul 2017 05:00:51 -0400 Received: from mail-pg0-f53.google.com ([74.125.83.53]:36604 "EHLO mail-pg0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752852AbdGCJAs (ORCPT ); Mon, 3 Jul 2017 05:00:48 -0400 Date: Mon, 3 Jul 2017 14:30:45 +0530 From: Viresh Kumar To: Arvind Yadav Cc: srinivas.pandruvada@linux.intel.com, lenb@kernel.org, rjw@rjwysocki.net, rafael.j.wysocki@intel.com, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] cpufreq: intel_pstate: constify attribute_group structures. Message-ID: <20170703090045.GD3532@vireshk-i7> References: <229e26ffc410cf4908c55ca0cb13906fd4bf4cf5.1499068985.git.arvind.yadav.cs@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <229e26ffc410cf4908c55ca0cb13906fd4bf4cf5.1499068985.git.arvind.yadav.cs@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1255 Lines: 35 On 03-07-17, 13:40, Arvind Yadav wrote: > attribute_groups are not supposed to change at runtime. All functions > working with attribute_groups provided by work with const > attribute_group. So mark the non-const structs as const. > > File size before: > text data bss dec hex filename > 15197 2552 40 17789 457d drivers/cpufreq/intel_pstate.o > > File size After adding 'const': > text data bss dec hex filename > 15261 2488 40 17789 457d drivers/cpufreq/intel_pstate.o > > Signed-off-by: Arvind Yadav > --- > drivers/cpufreq/intel_pstate.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c > index b7de5bd..4323f94 100644 > --- a/drivers/cpufreq/intel_pstate.c > +++ b/drivers/cpufreq/intel_pstate.c > @@ -1212,7 +1212,7 @@ static ssize_t store_min_perf_pct(struct kobject *a, struct attribute *b, > NULL > }; > > -static struct attribute_group intel_pstate_attr_group = { > +static const struct attribute_group intel_pstate_attr_group = { > .attrs = intel_pstate_attributes, > }; Acked-by: Viresh Kumar -- viresh