Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753834AbdGCJsK (ORCPT ); Mon, 3 Jul 2017 05:48:10 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51168 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753544AbdGCJsJ (ORCPT ); Mon, 3 Jul 2017 05:48:09 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 0F69885A07 Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=kraxel@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 0F69885A07 Message-ID: <1499075281.771.10.camel@redhat.com> Subject: Re: [PATCH] drm: ttm: virtio-gpu: dma-buf: Constify ttm_place structures. From: Gerd Hoffmann To: Arvind Yadav , airlied@linux.ie Cc: dri-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org Date: Mon, 03 Jul 2017 11:48:01 +0200 In-Reply-To: <25a189402a516a0142d9a4412da0a597c660a96a.1498981093.git.arvind.yadav.cs@gmail.com> References: <25a189402a516a0142d9a4412da0a597c660a96a.1498981093.git.arvind.yadav.cs@gmail.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Mon, 03 Jul 2017 09:48:09 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 777 Lines: 23 On Sun, 2017-07-02 at 13:11 +0530, Arvind Yadav wrote: > ttm_place are not supposed to change at runtime. All functions > working with ttm_place provided by work > with const ttm_place. So mark the non-const structs as const. > > File size before: >    text    data     bss     dec     hex > filename >    2315     184       0    2499     9c3 > drivers/gpu/drm/virtio/virtgpu_ttm.o > > File size After adding 'const': >    text    data     bss     dec     hex > filename >    2347     152       0    2499     9c3 > drivers/gpu/drm/virtio/virtgpu_ttm.o > > Signed-off-by: Arvind Yadav pushed to drm-misc-next (qxl patch too). cheers, Gerd