Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753278AbdGCLqr (ORCPT ); Mon, 3 Jul 2017 07:46:47 -0400 Received: from mail-wm0-f41.google.com ([74.125.82.41]:38873 "EHLO mail-wm0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752560AbdGCLqo (ORCPT ); Mon, 3 Jul 2017 07:46:44 -0400 Date: Mon, 3 Jul 2017 12:46:41 +0100 From: Lee Jones To: Benson Leung Cc: Thierry Escande , Benson Leung , linux-kernel@vger.kernel.org, enric.balletbo@collabora.com Subject: Re: [PATCH v2 3/3] cros_ec: Don't signal wake event for non-wake host events Message-ID: <20170703114641.2zivoeqiv7tk4bqu@dell> References: <1487102282-12259-1-git-send-email-thierry.escande@collabora.com> <1487102282-12259-4-git-send-email-thierry.escande@collabora.com> <20170627162353.GC39605@decatoncale.mtv.corp.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170627162353.GC39605@decatoncale.mtv.corp.google.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1474 Lines: 38 On Tue, 27 Jun 2017, Benson Leung wrote: > Hi Thierry, > > On Tue, Feb 14, 2017 at 08:58:02PM +0100, Thierry Escande wrote: > > From: Shawn Nematbakhsh > > > > The subset of wake-enabled host events is defined by the EC, but the EC > > may still send non-wake host events if we're in the process of > > suspending. Get the mask of wake-enabled host events from the EC and > > filter out non-wake events to prevent spurious aborted suspend > > attempts. > > > > Signed-off-by: Shawn Nematbakhsh > > Signed-off-by: Thierry Escande > > --- > > drivers/mfd/cros_ec.c | 13 ++++-- > > drivers/platform/chrome/cros_ec_proto.c | 76 ++++++++++++++++++++++++++++++--- > > include/linux/mfd/cros_ec.h | 5 ++- > > 3 files changed, 85 insertions(+), 9 deletions(-) > > > > Another use of cros_ec_get_next_event was introduced in cros_ec_lpc.c since > this patch was posted, so I went ahead and modified that too. > > Applied. Thanks. No need to change anything this time, but please note the "for my own reference" in my Ack in future. It typically means that I plan on pushing it through the MFD tree or that it requires further discussion (in the case that another Maintainer would prefer it go through their tree). -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog