Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754160AbdGCMEG (ORCPT ); Mon, 3 Jul 2017 08:04:06 -0400 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:33026 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753367AbdGCMED (ORCPT ); Mon, 3 Jul 2017 08:04:03 -0400 Date: Mon, 3 Jul 2017 13:03:51 +0100 From: Will Deacon To: Christoffer Dall Cc: Andrew Jones , Jintack Lim , Christoffer Dall , Marc Zyngier , Paolo Bonzini , Radim =?utf-8?B?S3LEjW3DocWZ?= , linux@armlinux.org.uk, Catalin Marinas , vladimir.murzin@arm.com, Suzuki K Poulose , mark.rutland@arm.com, james.morse@arm.com, lorenzo.pieralisi@arm.com, kevin.brodsky@arm.com, wcohen@redhat.com, shankerd@codeaurora.org, geoff@infradead.org, Andre Przywara , Eric Auger , anna-maria@linutronix.de, Shih-Wei Li , arm-mail-list , kvmarm@lists.cs.columbia.edu, KVM General , lkml - Kernel Mailing List Subject: Re: [RFC 21/55] KVM: arm64: Forward HVC instruction to the guest hypervisor Message-ID: <20170703120350.GC1573@arm.com> References: <1483943091-1364-1-git-send-email-jintack@cs.columbia.edu> <1483943091-1364-22-git-send-email-jintack@cs.columbia.edu> <20170222114758.GM26976@cbox> <20170703090850.GG4066@cbox> <20170703093156.m3ds2orbjcyooaag@kamzik.brq.redhat.com> <20170703095126.GH4066@cbox> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170703095126.GH4066@cbox> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2680 Lines: 54 On Mon, Jul 03, 2017 at 11:51:26AM +0200, Christoffer Dall wrote: > On Mon, Jul 03, 2017 at 11:31:56AM +0200, Andrew Jones wrote: > > On Mon, Jul 03, 2017 at 11:08:50AM +0200, Christoffer Dall wrote: > > > On Mon, Jun 26, 2017 at 11:21:25AM -0400, Jintack Lim wrote: > > > > On Wed, Feb 22, 2017 at 6:47 AM, Christoffer Dall wrote: > > > > > On Mon, Jan 09, 2017 at 01:24:17AM -0500, Jintack Lim wrote: > > > > >> +/* We forward all hvc instruction to the guest hypervisor. */ > > > > >> +int handle_hvc_nested(struct kvm_vcpu *vcpu) > > > > >> +{ > > > > >> + return kvm_inject_nested_sync(vcpu, kvm_vcpu_get_hsr(vcpu)); > > > > >> +} > > > > > > > > > > I don't understand the logic here or in the caller above. Do we really > > > > > forward *all" hvc calls to the guest hypervisor now, so that we no > > > > > longer support any hypercalls from the VM? That seems a little rough > > > > > and probably requires some more discussions. > > > > > > > > So I think if we run a VM with the EL2 support, then all hvc calls > > > > from the VM should be forwarded to the virtual EL2. > > > > > > But do we actually check if the guest has EL2 here? It seems you cann > > > handle_hvc_nested unconditionally when you have > > > OCNFIG_KVM_ARM_NESTED_HYP. I think that's what threw me off when first > > > reading your patch. > > > > > > > > > > > I may miss something obvious, so can you (or anyone) come up with some > > > > cases that the host hypervisor needs to directly handle hvc from the > > > > VM with the EL2 support? > > > > > > > > > > So I'm a little unsure what to say here. On one hand you are absolutely > > > correct, that architecturally if we emulated virtual EL2, then all > > > hypercalls are handled by the virtual EL2 (even hypercalls from virtual > > > EL2 which should become self-hypercalls). > > > > > > On the other hand, an enlightened guest may want to use hypercalls to > > > the hypervisor for some reason, but that would require some numbering > > > scheme to separate the two concepts. > > > > Yes, I've been thinking that a KVM generic vcpu needs to be enlightened, > > and to use a hypercall to get the host cpu's errata. If we head down that > > road, then even a vcpu emulating EL2 would need to be able to this. > > > > We could use SMC calls here a well, as the "conduit" as I believe the > ARM folks are calling it. We just need to agree somewhere (across > hypervisors preferably), that when you have virtual EL2, everything is > via SMC (even upcalls to a host hypervisor), and otherwise it's via HVC. Does that mean you require the CPU to implement EL3 if you want to use nested virtualisation? Will