Date: Mon, 16 Jun 2003 11:49:11 +0200
From: DervishD <raul@pleyades.net>
To: =?iso-8859-1?Q?J=F6rn?= Engel <joern@wohnheim.fh-wedel.de>
Cc: Linus Torvalds <torvalds@transmeta.com>,
       Linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [RESEND][PATCH] against mmap.c (do_mmap_pgoff) and a note
Message-ID: <20030616094911.GB43@DervishD>
References: <20030421110427.GA127@DervishD> <20030615102039.GA1063@wohnheim.fh-wedel.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20030615102039.GA1063@wohnheim.fh-wedel.de>
User-Agent: Mutt/1.4i
Organization: Pleyades
User-Agent: Mutt/1.4i <http://www.mutt.org>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1015
Lines: 38

 * J?rn Engel <joern@wohnheim.fh-wedel.de> dixit:
> > -	if (!len)
> > +	if (len == 0)
> No change.

    Just cosmethic, ask Dave S. Miller, he is the author of the
change, I'm just doing the patch for him.
 
> >  		return addr;
> >  
> > -	if (len > TASK_SIZE)
> > -		return -EINVAL;
> > -
> >  	len = PAGE_ALIGN(len);
> >  
> > +	if (len > TASK_SIZE || len == 0)
> > +		return -EINVAL;
> > +
> 
> PAGE_ALIGN(0) = 0
> PAGE_ALIGN(1) = PAGE_SIZE
> 
> Again, no change.

    There is a change in archs where TASK_SIZE is the entire
addressable space (like sparc64). Ask Dave S., again. The problem did
arise when TASK_SIZE is ~0. Then semantics change.
 
    Ra?l N??ez de Arenas Coronado

-- 
Linux Registered User 88736
http://www.pleyades.net & http://raul.pleyades.net/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/