Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754473AbdGCNHm (ORCPT ); Mon, 3 Jul 2017 09:07:42 -0400 Received: from mail.kernel.org ([198.145.29.99]:55786 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754018AbdGCNHl (ORCPT ); Mon, 3 Jul 2017 09:07:41 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A89EB22B5F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=helgaas@kernel.org Date: Mon, 3 Jul 2017 08:07:39 -0500 From: Bjorn Helgaas To: Ryder Lee Cc: Bjorn Helgaas , linux-pci@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] PCI: mediatek: Remove unnecessary PCI_REASSIGN_* flags Message-ID: <20170703130739.GD13824@bhelgaas-glaptop.roam.corp.google.com> References: <1499061300-55951-1-git-send-email-ryder.lee@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1499061300-55951-1-git-send-email-ryder.lee@mediatek.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 905 Lines: 27 On Mon, Jul 03, 2017 at 01:55:00PM +0800, Ryder Lee wrote: > The PCI_REASSIGN_ALL_RSRC and PCI_REASSIGN_ALL_BUS flags are not needed, > since we should automatically assign resources if the firmware hasn't done it. > > Signed-off-by: Ryder Lee Folded into pci/host-mediatek, thanks! > --- > drivers/pci/host/pcie-mediatek.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/pci/host/pcie-mediatek.c b/drivers/pci/host/pcie-mediatek.c > index 51c6118..5a9d858 100644 > --- a/drivers/pci/host/pcie-mediatek.c > +++ b/drivers/pci/host/pcie-mediatek.c > @@ -478,7 +478,6 @@ static int mtk_pcie_register_host(struct pci_host_bridge *host) > struct pci_bus *child; > int err; > > - pci_add_flags(PCI_REASSIGN_ALL_RSRC | PCI_REASSIGN_ALL_BUS); > host->busnr = pcie->busn.start; > host->dev.parent = pcie->dev; > host->ops = &mtk_pcie_ops; > -- > 1.9.1 >