Date: Mon, 16 Jun 2003 13:33:51 +0200
From: =?iso-8859-1?Q?J=F6rn?= Engel <joern@wohnheim.fh-wedel.de>
To: DervishD <raul@pleyades.net>
Cc: Linus Torvalds <torvalds@transmeta.com>,
       Linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [RESEND][PATCH] against mmap.c (do_mmap_pgoff) and a note
Message-ID: <20030616113351.GB18717@wohnheim.fh-wedel.de>
References: <20030421110427.GA127@DervishD> <20030615102039.GA1063@wohnheim.fh-wedel.de> <20030616094911.GB43@DervishD>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20030616094911.GB43@DervishD>
User-Agent: Mutt/1.3.28i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1103
Lines: 38

On Mon, 16 June 2003 11:49:11 +0200, DervishD wrote:
>  * J?rn Engel <joern@wohnheim.fh-wedel.de> dixit:
>  
> > >  		return addr;
> > >  
> > > -	if (len > TASK_SIZE)
> > > -		return -EINVAL;
> > > -
> > >  	len = PAGE_ALIGN(len);
> > >  
> > > +	if (len > TASK_SIZE || len == 0)
> > > +		return -EINVAL;
> > > +
> > 
> > PAGE_ALIGN(0) = 0
> > PAGE_ALIGN(1) = PAGE_SIZE
> > 
> > Again, no change.
> 
>     There is a change in archs where TASK_SIZE is the entire
> addressable space (like sparc64). Ask Dave S., again. The problem did
> arise when TASK_SIZE is ~0. Then semantics change.

True.  PAGE_ALIGN(-1) = 0 and that case would not get caught with the
old code.  Looks good to me.

J?rn

-- 
Public Domain  - Free as in Beer
General Public - Free as in Speech
BSD License    - Free as in Enterprise
Shared Source  - Free as in "Work will make you..."
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/