Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755805AbdGCOjc (ORCPT ); Mon, 3 Jul 2017 10:39:32 -0400 Received: from mail-oi0-f66.google.com ([209.85.218.66]:35413 "EHLO mail-oi0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753805AbdGCOj1 (ORCPT ); Mon, 3 Jul 2017 10:39:27 -0400 MIME-Version: 1.0 In-Reply-To: <1499089066.1935.77.camel@codethink.co.uk> References: <20170619152033.211450261@linuxfoundation.org> <20170619152034.086147988@linuxfoundation.org> <1498752917.1935.52.camel@codethink.co.uk> <20170703073153.GE5888@kroah.com> <1499089066.1935.77.camel@codethink.co.uk> From: Arnd Bergmann Date: Mon, 3 Jul 2017 16:39:25 +0200 X-Google-Sender-Auth: zRyc3uZn_nQUThjovAwNffOar1k Message-ID: Subject: Re: [PATCH 4.4 16/30] [media] pvrusb2: reduce stack usage pvr2_eeprom_analyze() To: Ben Hutchings Cc: Greg Kroah-Hartman , Linux Kernel Mailing List , "# 3.4.x" , Hans Verkuil , Mauro Carvalho Chehab Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 807 Lines: 24 On Mon, Jul 3, 2017 at 3:37 PM, Ben Hutchings wrote: > On Mon, 2017-07-03 at 09:47 +0200, Arnd Bergmann wrote: >> On Mon, Jul 3, 2017 at 9:31 AM, Greg Kroah-Hartman >> >> I think we probably want both of them backported to 4.4, but I don't see a >> dependency between them. > > Sorry, I mixed up two commits. The one actually needed to avoid a null > dereference is: > > commit 7cda4c5bae46ffca3abeadc4c1882d9325ee3102 > Author: Mauro Carvalho Chehab > Date: Thu Oct 13 10:51:20 2016 -0300 > > [media] tveeprom: use dev_foo() for printk messages > > Then "[media] tveeprom: print log messages using pr_foo()" is cleanup on > top of that. Ah, I see now. We do indeed need both of Mauro's patches before we can apply mine then. Arnd