Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753786AbdGCQLU convert rfc822-to-8bit (ORCPT ); Mon, 3 Jul 2017 12:11:20 -0400 Received: from prv-mh.provo.novell.com ([137.65.248.74]:49631 "EHLO prv-mh.provo.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752364AbdGCQLT (ORCPT ); Mon, 3 Jul 2017 12:11:19 -0400 Message-Id: <595A88C202000078001680C2@prv-mh.provo.novell.com> X-Mailer: Novell GroupWise Internet Agent 14.2.2 Date: Mon, 03 Jul 2017 10:11:14 -0600 From: "Jan Beulich" To: "Juergen Gross" Cc: , , Subject: Re: [Xen-devel] [PATCH] xen/balloon: don't online new memory initially References: <20170703154037.17851-1-jgross@suse.com> In-Reply-To: <20170703154037.17851-1-jgross@suse.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8BIT Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 432 Lines: 14 >>> On 03.07.17 at 17:40, wrote: > --- a/drivers/xen/xen-balloon.c > +++ b/drivers/xen/xen-balloon.c > @@ -59,6 +59,8 @@ static void watch_target(struct xenbus_watch *watch, > { > unsigned long long new_target; > int err; > + static bool watch_fired; > + static unsigned long target_diff; It would seem to me that the types of target_diff and new_target should match in width, but differ in signedness. Jan