Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932404AbdGCQ6v (ORCPT ); Mon, 3 Jul 2017 12:58:51 -0400 Received: from mail-lf0-f67.google.com ([209.85.215.67]:33550 "EHLO mail-lf0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752816AbdGCQ6q (ORCPT ); Mon, 3 Jul 2017 12:58:46 -0400 Date: Mon, 3 Jul 2017 18:58:44 +0200 From: Johan Hovold To: Dave Gerlach Cc: Tony Lindgren , Santosh Shilimkar , Russell King , Keerthy J , linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 5/5] ARM: OMAP2+: Create dummy platform_device for pm33xx Message-ID: <20170703165844.GD27842@localhost> References: <20170519200438.9502-1-d-gerlach@ti.com> <20170519200438.9502-6-d-gerlach@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170519200438.9502-6-d-gerlach@ti.com> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 710 Lines: 24 On Fri, May 19, 2017 at 03:04:38PM -0500, Dave Gerlach wrote: > Add amx3_common_pm_init to create a dummy platform_device for > pm33xx so that our pm33xx module can probe and am335x and am437x > platforms to enable basic suspend to mem and standby support. > > Signed-off-by: Dave Gerlach > --- > +void __init amx3_common_pm_init(void) > +{ > + struct platform_device_info devinfo = { }; You should make sure devinfo is zeroed, and also set .id to -1. > + struct am33xx_pm_platform_data *pdata; > + > + pdata = am33xx_pm_get_pdata(); > + devinfo.name = "pm33xx"; > + devinfo.data = pdata; > + devinfo.size_data = sizeof(*pdata); > + platform_device_register_full(&devinfo); > +} Johan