Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752970AbdGCUgv (ORCPT ); Mon, 3 Jul 2017 16:36:51 -0400 Received: from fllnx210.ext.ti.com ([198.47.19.17]:10721 "EHLO fllnx210.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752551AbdGCUgt (ORCPT ); Mon, 3 Jul 2017 16:36:49 -0400 Subject: Re: [PATCH v2] drm: tilcdc: tilcdc_tfp410: make of_device_ids const. To: Arvind Yadav , , CC: , References: From: Jyri Sarha Message-ID: Date: Mon, 3 Jul 2017 23:36:45 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1802 Lines: 54 On 06/28/17 08:42, Arvind Yadav wrote: > of_device_ids are not supposed to change at runtime. All functions > working with of_device_ids provided by work with const > of_device_ids. So mark the non-const structs as const. > > File size before: > text data bss dec hex filename > 1496 592 0 2088 828 drivers/gpu/drm/tilcdc/tilcdc_tfp410.o > > File size after constify: > text data bss dec hex filename > 1880 176 0 2056 808 drivers/gpu/drm/tilcdc/tilcdc_tfp410.o > > Signed-off-by: Arvind Yadav Thanks, I pick this up and push it in next merge window (for 4.14). However, both this and the bundled panel driver is going away as soon as I have time to do it, but it is unlikely to happen before v4.14. Best regards, Jyri > --- > Changes in v1: > Subject was not correct. > > drivers/gpu/drm/tilcdc/tilcdc_tfp410.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c b/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c > index aabfad8..236ca1e 100644 > --- a/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c > +++ b/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c > @@ -290,8 +290,6 @@ static int tfp410_modeset_init(struct tilcdc_module *mod, struct drm_device *dev > * Device: > */ > > -static struct of_device_id tfp410_of_match[]; > - > static int tfp410_probe(struct platform_device *pdev) > { > struct device_node *node = pdev->dev.of_node; > @@ -376,7 +374,7 @@ static int tfp410_remove(struct platform_device *pdev) > return 0; > } > > -static struct of_device_id tfp410_of_match[] = { > +static const struct of_device_id tfp410_of_match[] = { > { .compatible = "ti,tilcdc,tfp410", }, > { }, > }; >