Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752053AbdGDDhY (ORCPT ); Mon, 3 Jul 2017 23:37:24 -0400 Received: from mail-it0-f53.google.com ([209.85.214.53]:36972 "EHLO mail-it0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751673AbdGDDhW (ORCPT ); Mon, 3 Jul 2017 23:37:22 -0400 MIME-Version: 1.0 In-Reply-To: <1496733079-9410-1-git-send-email-tqnguyen@apm.com> References: <1496733079-9410-1-git-send-email-tqnguyen@apm.com> From: "Thang Q. Nguyen" Date: Tue, 4 Jul 2017 10:37:20 +0700 Message-ID: Subject: Re: [PATCH v1 1/1] usb:xhci: update condition to select bus->sysdev from parent device To: Mathias Nyman , Greg Kroah-Hartman , Sriram Dash , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Thang Nguyen , Phong Vo , Loc Ho , Tung Nguyen , patches Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1501 Lines: 37 On Tue, Jun 6, 2017 at 2:11 PM, Thang Q. Nguyen wrote: > For commit 4c39d4b949d3 ("usb: xhci: use bus->sysdev for DMA > configuration"), sysdev points to devices known to the system firmware > or hardware for DMA parameters. > However, the parent of the system firmware/hardware device checking > logic does not work in ACPI boot mode. This patch updates the formulation > to check this case in both DT and ACPI. > > Signed-off-by: Tung Nguyen > Signed-off-by: Thang Q. Nguyen > --- > drivers/usb/host/xhci-plat.c | 4 +++- > 1 files changed, 3 insertions(+), 1 deletions(-) > > diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c > index c04144b..e3e342a 100644 > --- a/drivers/usb/host/xhci-plat.c > +++ b/drivers/usb/host/xhci-plat.c > @@ -187,7 +187,9 @@ static int xhci_plat_probe(struct platform_device *pdev) > * 3. xhci_plat is grandchild of a pci device (dwc3-pci) > */ > sysdev = &pdev->dev; > - if (sysdev->parent && !sysdev->of_node && sysdev->parent->of_node) > + if (sysdev->parent && (sysdev->fwnode->type == FWNODE_PDATA) && > + (is_of_node(sysdev->parent->fwnode) || > + is_acpi_device_node(sysdev->parent->fwnode))) > sysdev = sysdev->parent; > #ifdef CONFIG_PCI > else if (sysdev->parent && sysdev->parent->parent && > -- > 1.7.1 > Hi, Do you have any comment on this patch? Regards, Thang Q. Nguyen