Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752202AbdGDGqq (ORCPT ); Tue, 4 Jul 2017 02:46:46 -0400 Received: from lucky1.263xmail.com ([211.157.147.132]:37667 "EHLO lucky1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750879AbdGDGqp (ORCPT ); Tue, 4 Jul 2017 02:46:45 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 1 X-MAIL-DELIVERY: 0 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-RL-SENDER: david.wu@rock-chips.com X-FST-TO: linux-kernel@vger.kernel.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: david.wu@rock-chips.com X-UNIQUE-TAG: X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH 3/5] pwm: rockchip: Move the configuration of polarity from rockchip_pwm_set_enable() to rockchip_pwm_config() To: Boris Brezillon Cc: thierry.reding@gmail.com, heiko@sntech.de, robh+dt@kernel.org, catalin.marinas@arm.com, briannorris@chromium.org, dianders@chromium.org, mark.rutland@arm.com, huangtao@rock-chips.com, linux-pwm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <1498739271-27431-1-git-send-email-david.wu@rock-chips.com> <1498739271-27431-4-git-send-email-david.wu@rock-chips.com> <20170703203640.697b8286@bbrezillon> From: "David.Wu" Message-ID: <681d6ce3-aae4-7d4f-2fec-e8af8f4f9436@rock-chips.com> Date: Tue, 4 Jul 2017 14:46:29 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170703203640.697b8286@bbrezillon> Content-Type: text/plain; charset=gbk; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 238 Lines: 8 Hi Boris, ?? 2017/7/4 2:36, Boris Brezillon ะด??: > Hm, maybe it's time to drop these custom hooks and implement > pwm_apply_v1 and pwm_apply_v2 instead. Okay, drop the enable and config hooks, only use the apply hook to instead them.