Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752194AbdGDHT1 (ORCPT ); Tue, 4 Jul 2017 03:19:27 -0400 Received: from Galois.linutronix.de ([146.0.238.70]:46282 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751631AbdGDHTZ (ORCPT ); Tue, 4 Jul 2017 03:19:25 -0400 Date: Tue, 4 Jul 2017 09:19:05 +0200 (CEST) From: Thomas Gleixner To: Dou Liyang cc: Colin King , Ingo Molnar , "H . Peter Anvin" , x86@kernel.org, Andrew Banman , Mike Travis , Dimitri Sivanich , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] x86/platform/uv/BAU: minor cleanup, make some local functions static In-Reply-To: <86c2556c-cc0e-b221-b81e-4433b61f0f82@cn.fujitsu.com> Message-ID: References: <20170703142258.18240-1-colin.king@canonical.com> <86c2556c-cc0e-b221-b81e-4433b61f0f82@cn.fujitsu.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 845 Lines: 27 On Tue, 4 Jul 2017, Dou Liyang wrote: > At 07/03/2017 10:22 PM, Colin King wrote: > > -int normal_busy(struct bau_control *bcp) > > +static int normal_busy(struct bau_control *bcp) > > In my opinion, there is no need to mark *normal_busy* static, remove it > directly. > > the commit c5d35d399e68(x86/UV2: Work around BAU bug) add it to > handle_uv2_busy(), but the handle_uv2_busy() is rewritten now. the > normal_busy is unused, can be remove. Correct. > By the way, there are also an other function named > uv_bau_message_interrupt() can be remove. Not so much. # git grep uv_bau_message_interrupt arch/x86/ arch/x86/entry/entry_64.S:apicinterrupt3 UV_BAU_MESSAGE uv_bau_message_intr1 uv_bau_message_interrupt arch/x86/platform/uv/tlb_uv.c:void uv_bau_message_interrupt(struct pt_regs *regs) Thanks, tglx