Subject: Re: [PATCH 4/5] pwm: rockchip: Add atomic updated feature for rk3328
To: Boris Brezillon <boris.brezillon@free-electrons.com>
Cc: thierry.reding@gmail.com, heiko@sntech.de, robh+dt@kernel.org,
        catalin.marinas@arm.com, briannorris@chromium.org,
        dianders@chromium.org, mark.rutland@arm.com, huangtao@rock-chips.com,
        linux-pwm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <1498739271-27431-1-git-send-email-david.wu@rock-chips.com>
 <1498739271-27431-5-git-send-email-david.wu@rock-chips.com>
 <20170703203957.03f3d1db@bbrezillon>
From: "David.Wu" <david.wu@rock-chips.com>
Message-ID: <05cccb3d-2b35-1878-6173-9a96adef17ba@rock-chips.com>
Date: Tue, 4 Jul 2017 15:37:54 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.2.1
MIME-Version: 1.0
In-Reply-To: <20170703203957.03f3d1db@bbrezillon>
Content-Type: text/plain; charset=gbk; format=flowed
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 321
Lines: 8

Hi Boris,

?? 2017/7/4 2:39, Boris Brezillon д??:
> Yet another customization. Don't you think we can extract common parts,
> expose them as helpers and then have 3 different pwm_ops (with 3
> different ->apply() implementation), one for each IP revision.

Sounds reasonable.I will try to implement 3 different apply().