Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752426AbdGDIfS (ORCPT ); Tue, 4 Jul 2017 04:35:18 -0400 Received: from hqemgate16.nvidia.com ([216.228.121.65]:11223 "EHLO hqemgate16.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752135AbdGDIfQ (ORCPT ); Tue, 4 Jul 2017 04:35:16 -0400 X-PGP-Universal: processed; by hqpgpgate102.nvidia.com on Tue, 04 Jul 2017 01:35:15 -0700 Subject: Re: [PATCH v2] devfreq: tegra: fix error return code in tegra_devfreq_probe() To: "Gustavo A. R. Silva" , MyungJoo Ham , Kyungmin Park , Chanwoo Choi , Thierry Reding CC: , , References: <20170703124738.GA3947@embeddedgus> From: Jon Hunter Message-ID: <5206e248-a3a7-8cb5-5d8f-a0c84bcb9e40@nvidia.com> Date: Tue, 4 Jul 2017 09:35:08 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <20170703124738.GA3947@embeddedgus> X-Originating-IP: [10.26.11.121] X-ClientProxiedBy: UKMAIL101.nvidia.com (10.26.138.13) To UKMAIL101.nvidia.com (10.26.138.13) Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1463 Lines: 48 On 03/07/17 13:47, Gustavo A. R. Silva wrote: > platform_get_irq() returns an error code, but the tegra-devfreq > driver ignores it and always returns -ENODEV. This is not correct, > and prevents -EPROBE_DEFER from being propagated properly. > > Notice that platform_get_irq() no longer returns 0 on error: > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=e330b9a6bb35dc7097a4f02cb1ae7b6f96df92af > > Print and propagate the return value of platform_get_irq on failure. > > Reviewed-by: Chanwoo Choi > Acked-by: MyungJoo Ham > Signed-off-by: Gustavo A. R. Silva > --- > Changes in v2: > Rewrite commit message. > > drivers/devfreq/tegra-devfreq.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/devfreq/tegra-devfreq.c b/drivers/devfreq/tegra-devfreq.c > index 214fff9..ae71215 100644 > --- a/drivers/devfreq/tegra-devfreq.c > +++ b/drivers/devfreq/tegra-devfreq.c > @@ -688,9 +688,9 @@ static int tegra_devfreq_probe(struct platform_device *pdev) > } > > irq = platform_get_irq(pdev, 0); > - if (irq <= 0) { > - dev_err(&pdev->dev, "Failed to get IRQ\n"); > - return -ENODEV; > + if (irq < 0) { > + dev_err(&pdev->dev, "Failed to get IRQ: %d\n", irq); > + return irq; > } > > platform_set_drvdata(pdev, tegra); Thanks. Acked-by: Jon Hunter Cheers Jon -- nvpublic