Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752284AbdGDKoA (ORCPT ); Tue, 4 Jul 2017 06:44:00 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:54642 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752040AbdGDKn7 (ORCPT ); Tue, 4 Jul 2017 06:43:59 -0400 Date: Tue, 4 Jul 2017 12:43:59 +0200 From: Greg Kroah-Hartman To: Vladimir Kondratiev Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] rmem: support for dma_addr different from phys_addr Message-ID: <20170704104359.GB29883@kroah.com> References: <20170704103438.21628-1-vladimir.kondratiev@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170704103438.21628-1-vladimir.kondratiev@intel.com> User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1266 Lines: 31 On Tue, Jul 04, 2017 at 01:34:38PM +0300, Vladimir Kondratiev wrote: > On some systems, dma address differs from physical one due to > various reasons. > > dma_init_coherent_memory is aware of it, it takes both > phys_addr_t and dma_addt_t arguments for memory block. > However, rmem_dma_device_init passes physical address for DMA one. > > Fix this, using phys_to_dma(). This assumes the whole buffer has > same offset between physical and dma addresses. > > Change-Id: Ic709312941ee4e1a37afb2ea25cbd759eabc009b What is that line for? You didn't use checkpatch.pl :( > Intel Israel (74) Limited > > This e-mail and any attachments may contain confidential material for > the sole use of the intended recipient(s). Any review or distribution > by others is strictly prohibited. If you are not the intended > recipient, please contact the sender and delete all copies. Ok, this is getting really annoying, according to my lawyers, I have to never respond to emails with this in it, and should just delete it. But I'll be nice, and tell you all to go fix all of Intel's email system to never send this stuff out again, it keeps happening over and over and over and is preventing you from contributing to open source projects. email is now deleted. greg k-h