Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752157AbdGDL1V (ORCPT ); Tue, 4 Jul 2017 07:27:21 -0400 Received: from foss.arm.com ([217.140.101.70]:44014 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751910AbdGDL1U (ORCPT ); Tue, 4 Jul 2017 07:27:20 -0400 Message-ID: <1499167621.2752.16.camel@arm.com> Subject: Re: [PATCH] bus: arm-ccn: constify attribute_group structures. From: Pawel Moll To: Arvind Yadav Cc: linux-kernel@vger.kernel.org, tglx@linutronix.de, mark.rutland@arm.com, mingo@kernel.org Date: Tue, 04 Jul 2017 12:27:01 +0100 In-Reply-To: <8cc3d7884405d61c8c22f33db9c0ed5b61146899.1499066893.git.arvind.yadav.cs@gmail.com> References: <8cc3d7884405d61c8c22f33db9c0ed5b61146899.1499066893.git.arvind.yadav.cs@gmail.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.18.5.2-0ubuntu3.2 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 791 Lines: 21 On Mon, 2017-07-03 at 13:01 +0530, Arvind Yadav wrote: > attribute_groups are not supposed to change at runtime. All functions > working with attribute_groups provided by work with const > attribute_group. So mark the non-const structs as const. > > File size before: >    text    data     bss     dec     hex filename >    9074    5592     416   15082    3aea drivers/bus/arm-ccn.o > > File size After adding 'const': >    text    data     bss     dec     hex filename >    9327    5336     416   15079    3ae7 drivers/bus/arm-ccn.o > > Signed-off-by: Arvind Yadav Looks fine to me. I'll queue it for the next time I push out CCN driver fixes (no dates promised, though...) Thanks! Paweł