Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752162AbdGDLgJ (ORCPT ); Tue, 4 Jul 2017 07:36:09 -0400 Received: from foss.arm.com ([217.140.101.70]:44094 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751910AbdGDLgI (ORCPT ); Tue, 4 Jul 2017 07:36:08 -0400 Date: Tue, 4 Jul 2017 12:35:13 +0100 From: Mark Rutland To: Arvind Yadav Cc: nico@linaro.org, mingo@kernel.org, lorenzo.pieralisi@arm.com, suzuki.poulose@arm.com, linux-kernel@vger.kernel.org, Punit Agrawal Subject: Re: [PATCH] bus: arm-cci: constify attribute_group structures. Message-ID: <20170704113513.GB21587@leverpostej> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1441 Lines: 47 On Mon, Jul 03, 2017 at 01:16:55PM +0530, Arvind Yadav wrote: > attribute_groups are not supposed to change at runtime. All functions > working with attribute_groups provided by work with const > attribute_group. So mark the non-const structs as const. > > Signed-off-by: Arvind Yadav >From a quick scan, this looks sane to me: Acked-by: Mark Rutland Suzuki, Punit, I guess one of you will queue this, assuming you're happy with it. Mark. > --- > drivers/bus/arm-cci.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/bus/arm-cci.c b/drivers/bus/arm-cci.c > index c49da15..64c75d2 100644 > --- a/drivers/bus/arm-cci.c > +++ b/drivers/bus/arm-cci.c > @@ -1445,16 +1445,16 @@ static ssize_t pmu_cpumask_attr_show(struct device *dev, > NULL, > }; > > -static struct attribute_group pmu_attr_group = { > +static const struct attribute_group pmu_attr_group = { > .attrs = pmu_attrs, > }; > > -static struct attribute_group pmu_format_attr_group = { > +static const struct attribute_group pmu_format_attr_group = { > .name = "format", > .attrs = NULL, /* Filled in cci_pmu_init_attrs */ > }; > > -static struct attribute_group pmu_event_attr_group = { > +static const struct attribute_group pmu_event_attr_group = { > .name = "events", > .attrs = NULL, /* Filled in cci_pmu_init_attrs */ > }; > -- > 1.9.1 >