Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752258AbdGDN2Y (ORCPT ); Tue, 4 Jul 2017 09:28:24 -0400 Received: from mail-wr0-f195.google.com ([209.85.128.195]:34921 "EHLO mail-wr0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750891AbdGDN2W (ORCPT ); Tue, 4 Jul 2017 09:28:22 -0400 Date: Tue, 4 Jul 2017 15:28:19 +0200 From: Pali =?utf-8?B?Um9ow6Fy?= To: Darren Hart Cc: Andy Lutomirski , platform-driver-x86@vger.kernel.org, Andy Shevchenko , Andy Lutomirski , Mario Limonciello , Rafael Wysocki , linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org Subject: Re: [PATCH v2] platform/x86: wmi-bmof: New driver to expose embedded Binary WMI MOF metadata Message-ID: <20170704132819.GE2102@pali> References: <20170606100440.GA4690@pali> <20170606170201.GC32509@fury> <201706062250.52564@pali> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <201706062250.52564@pali> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1046 Lines: 31 On Tuesday 06 June 2017 22:50:52 Pali Rohár wrote: > On Tuesday 06 June 2017 19:02:01 Darren Hart wrote: > > On Tue, Jun 06, 2017 at 12:04:40PM +0200, Pali Rohár wrote: > > > On Monday 05 June 2017 20:16:44 Andy Lutomirski wrote: > > > > +#define WMI_BMOF_GUID "05901221-D566-11D1-B2F0-00A0C9062910" > > > > +MODULE_ALIAS("wmi:" WMI_BMOF_GUID); > > > > > > Cannot we generate MODULE_ALIAS from module_wmi_driver()? IIRC it > > > is working for i2c drivers. > > > > I could see this being automated since we always use wmi:GUID, but it > > isn't currently. Happy to consider it as a follow on. > > > > Do you have a specific i2c example you think we should consider > > following? > > For i2c you can specify in driver code: > > MODULE_DEVICE_TABLE(i2c, id_table); > > And it automatically provides (via file.mod.c) all needed MODULE_ALIAS. > > So when we have wmi_bmof_id_table in driver, cannot we use this? > > MODULE_DEVICE_TABLE(wmi, wmi_bmof_id_table); Just reminder for above idea ↑↑↑ -- Pali Rohár pali.rohar@gmail.com