Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752248AbdGDPBE (ORCPT ); Tue, 4 Jul 2017 11:01:04 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:22821 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752038AbdGDPBC (ORCPT ); Tue, 4 Jul 2017 11:01:02 -0400 X-AuditID: b6c32a38-f793c6d000001aba-fc-595badab56b7 From: Bartlomiej Zolnierkiewicz To: "Gustavo A. R. Silva" Cc: linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] video: fbdev: aty: remove useless variable assignments in aty_var_to_crtc() Date: Tue, 04 Jul 2017 17:00:57 +0200 Message-id: <30595844.JA8gAC7Mhf@amdc3058> User-Agent: KMail/4.13.3 (Linux/3.13.0-96-generic; KDE/4.13.3; x86_64; ; ) In-reply-to: <20170626220518.GA9369@embeddedgus> MIME-version: 1.0 Content-transfer-encoding: 7Bit Content-type: text/plain; charset="us-ascii" X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrHIsWRmVeSWpSXmKPExsWy7bCmge7qtdGRBo9PaFusXLKfzeJE3wdW i8u75rA5MHusO6jq8XmTXABTFJdNSmpOZllqkb5dAlfGzAlrmQrOsVT0XbjN3MB4h7mLkZND QsBE4t/x2VC2mMSFe+vZuhi5OIQEdjBKbJzZxgLhfGaUOHJ2JSNMx7G+ScwQibWMEqtO/GCC cL4ySkw43M8GUsUmYCUxsX0VWIeIgLHEtef7mEBsZgFbidenz4DFhQWSJP4sPgIWZxFQlTje 2Alkc3DwCmhJnJwTDhIWFfCS2LKvHayEU8BA4vS2flYQm1dAUOLH5HssECPlJfbtn8oKYetI nD22jhHkHgmBx2wS7SvvM4PMlBCQldh0AMp0kZjzuw7iF2GJV8e3sEPYUhKNLx8yQdjTGSW2 /5aAGLMZ6MfdE6CKrCUOH78ItYtP4t3XHlaImbwSHW1CECUeEieOrGCBsB0lll/dBg2rZkaJ G0vfsk5glJ+F5IVZSF6YheSFBYzMqxjFUguKc9NTiw0LTPSKE3OLS/PS9ZLzczcxglOBlsUO xj3nfA4xCnAwKvHwajhFRQqxJpYVV+YeYpTgYFYS4Z28JjpSiDclsbIqtSg/vqg0J7X4EKM0 B4uSOK/o+msRQgLpiSWp2ampBalFMFkmDk6pBkYdl7+s3+c6LvEsKPrTXPD3dtEMzeneu18H 8sUFHFMJa9JcUlGRtyxMdoXX9e08ET6Xmq4ce19jrMIUup4xu+RdfMKR+T6bTjfPXOLg9r3D 19ZsZ221seoE95A274WyAlybHxU4L3VI8bseE/OAc4n3F69z14zcTv0XE6+5dSKpva4m+E3u fyWW4oxEQy3mouJEALemUWwBAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpikeLIzCtJLcpLzFFi42I5/e+xoO7qtdGRBle3ilisXLKfzeJE3wdW i8u75rA5MHusO6jq8XmTXABTlJtNRmpiSmqRQmpecn5KZl66rVJoiJuuhZJCXmJuqq1ShK5v SJCSQlliTimQZ2SABhycA9yDlfTtEtwyZk5Yy1RwjqWi78Jt5gbGO8xdjJwcEgImEsf6JkHZ YhIX7q1n62Lk4hASWM0osefOJiaQhJDAV0aJXTeDQWw2ASuJie2rGEFsEQFjiWvP94HVMAvY Srw+fQYsLiyQJHHn5F0wm0VAVeJ4YydQDQcHr4CWxMk54SBhUQEviS372sFaOQUMJE5v62eF 2NvKKDHr6HZWkASvgKDEj8n3WCDmy0vs2z+VFcLWkli/8zjTBEaBWUjKZiEpm4WkbAEj8ypG rtSC4tz03GKjAsNNjMDw33ZYy38H44+z0YcYBTgYlXh4G1yiIoVYE8uKK3MPMUpwMCuJ8MYu j44U4k1JrKxKLcqPLyrNSS0+xGgK9NJEZinR5HxgbOaVxBuaWBqZGJiZGRoZGJspifNOCPwS ISSQnliSmp2aWpBaBNPHxMEp1cAofN5DZcKjWVsZtHeFXfflW3dvj+ySxRc4DxycwfHSqGnP SXHTRfP3HpTdOavYmUHW6fyZqUF5tmuC/pR1Cl58GFodIL38sm7dgpcregQOT/6rerNEycE6 89oKkb3KJ9qPHjWrqd2iHOjXu+JPqT3THB/xszUMfrIKu96pbvLeeGKiG9/UhJZEJZbijERD Leai4kQAW2W/kJUCAAA= X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170704150059epcas1p4c186eefabc8484cbb3bd3e95e241c200 X-Msg-Generator: CA X-Sender-IP: 182.195.42.79 X-Local-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRvsgrzshLHsoITsnpAbU2VuaW9yIFNvZnR3YXJlIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRtTYW1zdW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBF?= =?UTF-8?B?bmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 101P X-CMS-RootMailID: 20170626220521epcas2p21e20ebaf7d36ec6d7a5cd54b81afdb4c X-RootMTR: 20170626220521epcas2p21e20ebaf7d36ec6d7a5cd54b81afdb4c References: <20170626220518.GA9369@embeddedgus> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 570 Lines: 18 On Monday, June 26, 2017 05:05:18 PM Gustavo A. R. Silva wrote: > Value assigned to variable vdisplay at line 990 is overwritten > at line 1039 before it can be used. Also, variable assignment > at line 987 is the same as at line 1039. This makes such > variable assignments useless. > > Remove these variable assignments and the code related. > > Addresses-Covertity-ID: 1226900 > Signed-off-by: Gustavo A. R. Silva Patch queued for 4.13, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics