Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752241AbdGDPOm (ORCPT ); Tue, 4 Jul 2017 11:14:42 -0400 Received: from mail-io0-f195.google.com ([209.85.223.195]:35209 "EHLO mail-io0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752052AbdGDPOl (ORCPT ); Tue, 4 Jul 2017 11:14:41 -0400 MIME-Version: 1.0 X-Originating-IP: [2a02:168:5640:0:960b:2678:e223:c1c6] In-Reply-To: <20170629102559.al74da7xhcdpahbb@phenom.ffwll.local> References: <1498057734-14622-1-git-send-email-daniel.vetter@ffwll.ch> <149805863799.15021.15278760577807511996@mail.alporthouse.com> <20170626161630.u4ubdzgxr37o63ip@phenom.ffwll.local> <20170629102559.al74da7xhcdpahbb@phenom.ffwll.local> From: Daniel Vetter Date: Tue, 4 Jul 2017 17:14:39 +0200 X-Google-Sender-Auth: ty7T65gv9JGjVQkGJCCS_FHc2ek Message-ID: Subject: Re: [PATCH] BUG-REPORT: snd-hda: hacked-together EPROBE_DEFER support To: Takashi Iwai , Chris Wilson , Intel Graphics Development , Guneshwor Singh , Hardik T Shah , Libin Yang , "Subhransu S. Prusty" , Vinod Koul , Julia Lawall , Jaroslav Kysela , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 904 Lines: 22 On Thu, Jun 29, 2017 at 12:25 PM, Daniel Vetter wrote: >> Now I took a closer look, and this appears rather like a brown paper >> bag bug, not about the deferred probe or module dependency. >> The fix patch is below. Could you check whether it works? > > Yay, this works! > > Tested-by: Daniel Vetter Next one: i915 module reloading is broken because something is holding onto a module reference and doesn't drop it. Didn't check which sets of patches introduced this, but iirc this worked last week. Disabling hda-intel gets in Kconfig gets rid of the problem, so I assume something in the sound driver is leaking that reference ... It's also causing lots and lots of red in our CI :( If we can't fix this we need to disable snd-hda-intel there too. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch