Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752260AbdGDP0r (ORCPT ); Tue, 4 Jul 2017 11:26:47 -0400 Received: from www62.your-server.de ([213.133.104.62]:54011 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752173AbdGDP0p (ORCPT ); Tue, 4 Jul 2017 11:26:45 -0400 Message-ID: <595BB3AF.3000304@iogearbox.net> Date: Tue, 04 Jul 2017 17:26:39 +0200 From: Daniel Borkmann User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Colin King , Alexei Starovoitov , "David S . Miller" , netdev@vger.kernel.org CC: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, Lawrence Brakmo Subject: Re: [PATCH][bpf-next] bpf: add missing break in for the TCP_BPF_SNDCWND_CLAMP case References: <20170704152112.18623-1-colin.king@canonical.com> In-Reply-To: <20170704152112.18623-1-colin.king@canonical.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated-Sender: daniel@iogearbox.net Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1048 Lines: 34 [ +Lawrence ] On 07/04/2017 05:21 PM, Colin King wrote: > From: Colin Ian King > > There appears to be a missing break in the TCP_BPF_SNDCWND_CLAMP case. > Currently the non-error path where val is greater than zero falls through > to the default case that sets the error return to -EINVAL. Add in > the missing break. > > Detected by CoverityScan, CID#1449376 ("Missing break in switch") > > Fixes: 13bf96411ad2 ("bpf: Adds support for setting sndcwnd clamp") > Signed-off-by: Colin Ian King Acked-by: Daniel Borkmann > --- > net/core/filter.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/net/core/filter.c b/net/core/filter.c > index 94169572d002..c7f737058d89 100644 > --- a/net/core/filter.c > +++ b/net/core/filter.c > @@ -2867,6 +2867,7 @@ BPF_CALL_5(bpf_setsockopt, struct bpf_sock_ops_kern *, bpf_sock, > tp->snd_cwnd_clamp = val; > tp->snd_ssthresh = val; > } > + break; > default: > ret = -EINVAL; > } >